Copilot reviewer improvements for 2026-09-22 - #54061
Merged
Billy O'Neal (BillyONeal) merged 4 commits intoSep 25, 2026
Merged
Billy O'Neal (BillyONeal) merged 4 commits into
Billy O'Neal (BillyONeal) merged 4 commits into
Conversation
These changes are from washing our shared code review instructions through GPT-6-Astra and Claude-Opus-5.5, asking them to clarify and confirm each other's work. I still have not seen a review done better by these more expensive models than 5.6-Sol and 5.6-Sol remains substantially cheaper, so I'm expecting to keep using Sol. I have not had time to do a full A/B test comparing Sol with Astra for a whole day's reviews yet though. Other things I tried to get them to fix: * The "contributor feedback" block I usually post back to folks before often described situations as a command, like "contributor you are bad you must do XYZ", whereas what contributor feedback *should* be is "your changes create this problem, you may be able to fix it by doing XYZ". Contributors should feel open to fixing things in their own way, they aren't subservient to maintainers. It's our job as maintainers to convince contributors of things. * Often the old rules would clobber my shared VCPKG_DOWNLOADS and force re-fetching a bunch of stuff. * Fixed direct-include instructions to not have Windows assumptions.
…fixes. An example of what I *want* this to do is something like SunBlack#87 -- I have not actually tested that yet.
Copilot started reviewing on behalf of
Billy O'Neal (BillyONeal)
September 23, 2026 04:14
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The new fix workflow has an unresolved cross-platform executable invocation issue and warrants human review.
Review effort: Balanced
Findings: None
What changed in this PR
Improves vcpkg review guidance and adds an experimental workflow for applying reviewed fixes.
Changes:
- Clarifies handoffs, workspace isolation, cache handling, and validation.
- Updates single and batch review orchestration.
- Adds a reviewed-PR fix and push workflow.
| File | Description |
|---|---|
.github/skills/shared/review-vcpkg-pr-guide.md |
Refines shared review and handoff guidance. |
.github/skills/review-vcpkg-prs-today/SKILL.md |
Improves batch workspace and report coordination. |
.github/skills/review-vcpkg-pr/SKILL.md |
Clarifies paths and preserves download caches. |
.github/skills/fix-reviewed-vcpkg-pr/SKILL.md |
Adds the fix workflow; its vcpkg invocation has an unresolved cross-platform issue. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Billy O'Neal (BillyONeal)
changed the title
Mahmoud Saleh (MahmoudGSaleh)
previously approved these changes
Sep 23, 2026
Billy O'Neal (BillyONeal)
marked this pull request as ready for review
September 25, 2026 05:26
Billy O'Neal (BillyONeal)
enabled auto-merge (squash)
September 25, 2026 05:27
Mahmoud Saleh (MahmoudGSaleh)
approved these changes
Sep 25, 2026
Billy O'Neal (BillyONeal)
deleted the
reviewer-improvements-2026-09-22
branch
September 25, 2026 20:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are from washing our shared code review instructions
through GPT-6-Astra and Claude-Opus-5.5, asking them to clarify and
confirm each other's work. I still have not seen a review done better
by these more expensive models than 5.6-Sol and 5.6-Sol remains
substantially cheaper, so I'm expecting to keep using Sol. I have not
had time to do a full A/B test comparing Sol with Astra for a whole
day's reviews yet though.
Other things I tried to get them to fix:
often described situations as a command, like "contributor you are bad
you must do XYZ", whereas what contributor feedback should be is "your
changes create this problem, you may be able to fix it by doing XYZ".
Contributors should feel open to fixing things in their own way, they
aren't subservient to maintainers. It's our job as maintainers to
convince contributors of things.
re-fetching a bunch of stuff.
Also added an experimental "fix-reviewed-vcpkg-pr" which tries to make
the "for contributors" changes like
SunBlack#87
And also I just realized that copilot overrode my local git commit settings and so claims both of the commits here. It certainly helped and as I described above it did things but I've fixed that myself for the future.