Skip to content

Fix si_code=, si_addr=undefined. - #14608

Merged
sean-mcmanus merged 3 commits into
mainfrom
seanmcm/fixEmptyUndefinedSignalInfo
Jul 27, 2026
Merged

Fix si_code=, si_addr=undefined.#14608
sean-mcmanus merged 3 commits into
mainfrom
seanmcm/fixEmptyUndefinedSignalInfo

Conversation

@sean-mcmanus

@sean-mcmanus sean-mcmanus commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

I noticed this in the crash call stack data.

Fixed by Copilot with Claude Opus 4.8 (in VS Code).

@sean-mcmanus
sean-mcmanus requested a review from a team as a code owner July 26, 2026 20:16
@github-project-automation github-project-automation Bot moved this to Pull Request in cpptools Jul 26, 2026
@sean-mcmanus
sean-mcmanus requested a review from Copilot July 26, 2026 20:16

This comment was marked as resolved.

Sign in to view

@sean-mcmanus
sean-mcmanus requested a review from Copilot July 26, 2026 20:34
Copilot AI reviewed Jul 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

bobbrow
bobbrow reviewed Jul 27, 2026
View reviewed changes
Comment thread Extension/src/LanguageServer/extension.ts
@sean-mcmanus
sean-mcmanus marked this pull request as draft July 27, 2026 17:50
@sean-mcmanus
sean-mcmanus marked this pull request as ready for review July 27, 2026 18:23
@sean-mcmanus
sean-mcmanus merged commit 4774d95 into main Jul 27, 2026
6 checks passed
@sean-mcmanus
sean-mcmanus deleted the seanmcm/fixEmptyUndefinedSignalInfo branch July 27, 2026 19:42
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Jul 27, 2026
sean-mcmanus added a commit that referenced this pull request Jul 28, 2026
@sean-mcmanus @Colengms
@kuchungmsft @bobbrow @dependabot @HuzaifaAbdulRehman @owevertonguedes
Merge for 1.33.5 (pre-release) (#14615)
a3d2457 
* Some IntelliSense loc changes. (#14571)

* Support requests of multiple custom configs (#14582)

* Add an opt-in for capturing sanitizer logs from the language server (#14573)

* Add an opt-in for capturing sanitizer logs from the language server

* Add localizable strings for --check headless validation (#14578)

* Add localizable strings for --check headless validation

Adds 13 native strings backing the mscppls --check mode (the clangd-style
headless validation of a compile_commands.json file): the two --help entries
and the setup/usage error messages.

* No lock on placeholders

* Fix LOC locks

* send telemetry for language client errors (#14577)

* Bump brace-expansion and @vscode/vsce in /Themes (#14591)

Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) to 5.0.7 and updates ancestor dependency [@vscode/vsce](https://github.com/Microsoft/vsce). These dependencies need to be updated together.


Updates `brace-expansion` from 1.1.13 to 5.0.7
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@v1.1.13...v5.0.7)

Updates `@vscode/vsce` from 3.9.1 to 3.9.2
- [Release notes](https://github.com/Microsoft/vsce/releases)
- [Commits](microsoft/vscode-vsce@v3.9.1...v3.9.2)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 5.0.7
  dependency-type: indirect
- dependency-name: "@vscode/vsce"
  dependency-version: 3.9.2
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix portable ps command for remote process picker (#14592)

* Fix portable remote process ps command

* Bump fast-uri from 3.1.2 to 3.1.4 in /Themes (#14593)

Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.2 to 3.1.4.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](fastify/fast-uri@v3.1.2...v3.1.4)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump linkify-it from 5.0.1 to 5.0.2 in /ExtensionPack (#14594)

Bumps [linkify-it](https://github.com/markdown-it/linkify-it) from 5.0.1 to 5.0.2.
- [Changelog](https://github.com/markdown-it/linkify-it/blob/master/CHANGELOG.md)
- [Commits](markdown-it/linkify-it@5.0.1...5.0.2)

---
updated-dependencies:
- dependency-name: linkify-it
  dependency-version: 5.0.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump linkify-it from 5.0.1 to 5.0.2 in /Extension (#14596)

Bumps [linkify-it](https://github.com/markdown-it/linkify-it) from 5.0.1 to 5.0.2.
- [Changelog](https://github.com/markdown-it/linkify-it/blob/master/CHANGELOG.md)
- [Commits](markdown-it/linkify-it@5.0.1...5.0.2)

---
updated-dependencies:
- dependency-name: linkify-it
  dependency-version: 5.0.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sean McManus <seanmcm@microsoft.com>

* Bump js-yaml from 4.2.0 to 4.3.0 in /Extension (#14597)

Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.2.0 to 4.3.0.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.2.0...4.3.0)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.3.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sean McManus <seanmcm@microsoft.com>

* Update dependencies. (#14598)

* Fix build tools walkthrough for VS 2026. (#14589)

* Bump fast-uri from 3.1.3 to 3.1.4 in /ExtensionPack (#14599)

Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.3 to 3.1.4.
- [Release notes](https://github.com/fastify/fast-uri/releases)
- [Commits](fastify/fast-uri@v3.1.3...v3.1.4)

---
updated-dependencies:
- dependency-name: fast-uri
  dependency-version: 3.1.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update dependencies again. (#14600)

* Update .gitignore for installed bin files. (#14606)

* Skip terminate_handler( frames. (#14609)

* Fix si_code=, si_addr=undefined. (#14608)

* Fix si_code=, si_addr=undefined.

* Update brace-expansion. (#14610)

* Update ThirdPartyNotices.txt (#14611)

* Update ThirdPartyNotices.txt

* Normalize JSON trailing newlines. (#14579)

* Unify json newlines.

* Use PowerShell call operator when shell integration is unavailable (#14585)

"Run C/C++ File" builds the command with buildShellCommandLine and sends
it via sendText when the terminal has no shell integration. That path
quotes a program path containing spaces but never prepends the call
operator, so PowerShell evaluates the quoted path as a string literal and
echoes it instead of running the program.

The shell-integration path already handles this, so extract its PowerShell
detection into isPowerShellTerminal() and reuse it in the sendText path.

Closes #14583

Co-authored-by: Sean McManus <seanmcm@microsoft.com>
Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com>

* Update changelog for 1.33.5. (#14613)

* Update changelog for 1.33.5.
* Update version to 1.33.5.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Colen Garoutte-Carson <49173979+Colengms@users.noreply.github.com>
Co-authored-by: Glen Chung <105310954+kuchungmsft@users.noreply.github.com>
Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HuzaifaAbdulRehman <143286445+HuzaifaAbdulRehman@users.noreply.github.com>
Co-authored-by: Weverton Guedes <146861752+owevertonguedes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobbrow bobbrow bobbrow left review comments
Copilot code review Copilot Copilot left review comments
@Colengms Colengms Colengms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

cpptools
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sean-mcmanus @bobbrow @Colengms