Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Extension/.scripts/installAndCopyBinaries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { runVSCodeCommand } from '@vscode/test-electron';
import { writeFile } from 'node:fs/promises';
import { join } from 'node:path';
import { $root, error, heading, note } from './common';
import { $root, error, heading, note, warn } from './common';
import * as copy from './copyExtensionBinaries';
import { install, isolated, options } from "./vscode";

Expand All @@ -24,7 +24,9 @@ export async function main() {
console.log(result.stdout.toString());
}
if (result.stderr) {
error(result.stderr.toString());
// runVSCodeCommand resolves only when the command succeeds (it throws on a non-zero exit), so stderr here is
// non-fatal output such as Node deprecation warnings and must not be reported as an error.
warn(result.stderr.toString());
}

const binaryVersion = await copy.main(isolated);
Expand Down
1 change: 1 addition & 0 deletions Extension/.scripts/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const filters = [
/^Unexpected token A/,
/Cannot register 'cmake.cmakePath'/,
/\[DEP0005\] DeprecationWarning/,
/\[DEP0169\] DeprecationWarning/,
/--trace-deprecation/,
/Iconv-lite warning/,
/^Extension '/,
Expand Down
Loading