Skip to content

Pin test VS Code version to 1.130.0 to unbreak macOS CI - #14618

Merged
sean-mcmanus merged 1 commit into
mainfrom
seanmcm/devbox2-wsl/agent6/pin-test-vscode-version
Jul 29, 2026
Merged

Pin test VS Code version to 1.130.0 to unbreak macOS CI#14618
sean-mcmanus merged 1 commit into
mainfrom
seanmcm/devbox2-wsl/agent6/pin-test-vscode-version

Conversation

@sean-mcmanus

@sean-mcmanus sean-mcmanus commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

The macOS CI legs are failing deterministically on every run because the integration tests download the newest stable VS Code (1.131.0, released today) and the installed @vscode/test-electron (^2.3.10) cannot launch its macOS arm64 bundle:

✔ Downloaded VS Code into .../vscode-darwin-arm64-1.131.0
✔ Validated version: 1.131.0
Test error: Error: spawn .../vscode-darwin-arm64-1.131.0/Visual Studio Code.app/Contents/MacOS/Electron ENOENT
Exit code: -2

The scenario tests resolve the test VS Code via downloadAndUnzipVSCode(options) with no pinned version, so they always pull latest stable — meaning a brand-new release can break CI for main and every open PR at once (Linux/Windows currently pass; only macOS is affected). This pins the downloaded test VS Code to 1.130.0 (the last release that launches under the current @vscode/test-electron) so CI is deterministic again.

Follow-up (separate change): bump @vscode/test-electron so newer stable releases launch, then the pin can be raised or removed.

This PR was created by Copilot with Claude Opus 4.8 (in VS Code). Any PR comments starting with Copilot says: are generated by Copilot.

The installed @vscode/test-electron cannot launch the VS Code 1.131.0 macOS arm64 bundle (spawn Electron ENOENT), which fails the integration-test steps on every run. Pin the downloaded test VS Code to 1.130.0 (the last release that launches) until @vscode/test-electron is bumped to handle newer stable releases.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the VS Code version used by the extension’s integration/scenario test harness so macOS CI no longer breaks when a new stable VS Code release ships that the current @vscode/test-electron cannot launch on macOS arm64.

Changes:

  • Introduces a testVSCodeVersion constant (1.130.0) to pin the downloaded VS Code build used for tests.
  • Passes the pinned version into downloadAndUnzipVSCode via the exported options object.
  • Adds inline comment context explaining the macOS arm64 failure mode and why the pin is necessary.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sean-mcmanus
sean-mcmanus merged commit 0c7a60d into main Jul 29, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Jul 29, 2026
@sean-mcmanus
sean-mcmanus deleted the seanmcm/devbox2-wsl/agent6/pin-test-vscode-version branch July 29, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants