Reduce settings change noise - #14622
Open
bobbrow wants to merge 1 commit into
Open
Conversation
Colengms
approved these changes
Jul 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces unnecessary Language Server settings-change handling by filtering onDidChangeSettings to only run when configuration changes affect relevant settings sections, lowering native-side no-op processing.
Changes:
- Adds
ConfigurationChangeEvent.affectsConfiguration(...)filtering to skip irrelevant configuration change events. - Limits settings-change propagation to the
C_Cpp,files,editor,search, andworkbenchsections (scoped per client root URI).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+296
to
+298
| if (['C_Cpp', 'files', 'editor', 'search', 'workbench'].some(section => event.affectsConfiguration(section, client.RootUri))) { | ||
| void client.onDidChangeSettings(event).catch(logAndReturn.undefined); | ||
| } |
sean-mcmanus
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the other PR for ensuring language client readiness, we saw excessive calls to
onDidChangeSettings. These have been around for a while and it turns out that there is a filtering API on the event that we can use to skip over settings changes that we don't care about. It's not perfectly granular, but does reduce the number of "no op" settings change events we need to process on the native side.Tested with single folder workspace, multi-root workspace, and no folder opened workspace.