Repository navigation
browser: support attach with approval-based remote debugging - #2436
Merged
Connor Peet (connor4312) merged 1 commit intoOct 13, 2026
Merged
Conversation
Chrome and Edge can turn on remote debugging from chrome://inspect/#remote-debugging or edge://inspect/#remote-debugging. This server does not support HTTP discovery, and each WebSocket connection shows an approval prompt in the browser. Now, browser attach supports this mode. - Find the browser endpoint from the DevToolsActivePort file. Use the new optional `userDataDir` attach option, or else the default user data directories of Chrome, Chromium, and Edge. - Do the HTTP discovery attach and the DevToolsActivePort attach in parallel. Use the first connection that succeeds, and stop the other attach. If the two attaches fail, show the HTTP discovery error. - Make one WebSocket connection with no timeout while the user approves, so that the browser does not show more than one prompt. Add `WebSocketTransport.open` for one attempt. - Show a cancellable DAP progress while the browser waits for approval. If the user cancels it, stop the full launch and end the debug session. - Add the `userDataDir` attach option to the schema, documentation, and changelog. Fixes #2435 (Commit message generated by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Connor Peet (connor4312)
enabled auto-merge (squash)
October 13, 2026 22:12
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
roblourens
approved these changes
Oct 13, 2026
Connor Peet (connor4312)
deleted the
connor4312/approval-remote-debugging
branch
October 13, 2026 22:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome and Edge can turn on remote debugging from chrome://inspect/#remote-debugging or
edge://inspect/#remote-debugging. This server does not support HTTP discovery, and each
WebSocket connection shows an approval prompt in the browser. Now, browser attach supports
this mode.
userDataDirattach option, or else the default user data directories of Chrome,Chromium, and Edge.
connection that succeeds, and stop the other attach. If the two attaches fail, show the
HTTP discovery error.
does not show more than one prompt. Add
WebSocketTransport.openfor one attempt.it, stop the full launch and end the debug session.
userDataDirattach option to the schema, documentation, and changelog.Fixes #2435
(Commit message generated by Copilot)