Repository navigation
fix: keep the outer range when Range.simplify merges a contained range - #2441
Merged
Connor Peet (connor4312) merged 1 commit intoOct 26, 2026
Conversation
Connor Peet (connor4312)
enabled auto-merge (squash)
October 23, 2026 15:26
Dmitriy Vasyura (dmitrivMS)
approved these changes
Oct 26, 2026
Bhavya U (bhavyaus)
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Range.simplifyalways took the next range's end when merging. If the next range sits inside the current one, the merged range shrinks to the inner end, and later ranges that the outer range still covers come back as separate pieces:The result is used by
Thread.getCurrentSkipListas theskipListfor step over/into. For WASM/DWARF frames that list mixes inlined callee ranges with the current line's ranges, so a contained range can cut off the tail of a region that should be skipped. The merge now only extends the current range when the next one ends later. This matchessortAndMergeRangesin DevTools' DebuggerModel.positions.test.tsmocha file. The new test fails on main (Range[0:0 -> 0:5], Range[0:7 -> 0:8]) and all 7 pass with the change.npm run test:unit, 297 passing. The 8 NodeBinaryProvider failures also fail locally on main.npm run test:types, plusdprint checkandeslint --max-warnings=0on both files: clean.