Skip to content

agentHost: update Copilot SDK to 1.0.17-preview.5 - #339835

Merged
roblourens merged 1 commit into
mainfrom
agents/upgrade-copilot-sdk-preview-five
Oct 5, 2026
Merged

roblourens merged 1 commit into
mainfrom
agents/upgrade-copilot-sdk-preview-five

Conversation

@roblourens

@roblourens roblourens commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Upgrades the root and remote-server @github/copilot-sdk dependency from 1.0.17-preview.4 to 1.0.17-preview.5, with the SDK-bundled runtime pin updated to 1.0.92-5. Both lockfiles were regenerated by running npm install from the repository root, and their changes are confined to the SDK and its platform packages.

This is a follow-up to merged #339423, based on current main rather than extending the old PR.

SDK compatibility

Preview.5 adds AccountAuthInfo, a credential-free provider-owned account that exposes login directly and does not have copilotUser. Update connector account matching to read that login through the SDK's discriminant instead of assuming a Copilot-user payload. Parameterize the existing launcher test for token-callback and provider-owned accounts, including a different-login account that must not be selected. The initial SDK compilation error is resolved without casts or narrowed production types.

No E2E assertions, gates, fixtures, prompt baselines, or AHP baselines were changed.

Validation

  • npm install — passed in the repository root. Root/remote SDK and runtime pins were checked against their installed packages.
  • npm run compile-client — passed with zero errors after handling the new authentication variant.
  • env -u COPILOT_HOME VSCODE_SKIP_PRELAUNCH=1 ./scripts/test.sh --run src/vs/platform/agentHost/test/node/copilotSessionLauncher.test.ts — passed: 99 tests, including both connector account variants.
  • npm run eslint -- src/vs/platform/agentHost/node/copilot/copilotSessionLauncher.ts src/vs/platform/agentHost/test/node/copilotSessionLauncher.test.ts — passed.
  • VSCODE_SKIP_PRELAUNCH=1 ./scripts/test-integration.sh --runGlob '**/agentHost/test/node/{providerIntegration/*,e2e/providers/copilotPromptsE2E,e2e/providers/codexAgentHostLive}.integrationTest.js' — clean repeat passed: 70 tests and 6 existing skips. The initial run hit the unchanged Codex plugin-MCP advertisement failure; that exact test passed an isolated retry, and the entire batch then passed without changes.
  • VSCODE_SKIP_PRELAUNCH=1 npm run test-agent-host-e2e — initial attempt passed conformance, Claude, Codex, Copilot, and all five OTel scenarios, but the managed-settings entrypoint timed out during startup. Its complete isolated entrypoint passed an unchanged retry.
  • VSCODE_SKIP_PRELAUNCH=1 npm run test-agent-host-e2e -- --jobs 2 — clean full strict replay repeat passed: all six entrypoints (conformance, Claude, Codex, Copilot, Copilot OTel, Copilot managed-settings diagnostics), 842 passing and 107 existing skips.
  • git diff --check and commit hygiene — passed.

GitHub Code OSS run 37341675492 passed on commit d4bb3c96cbc, including Windows/Linux/macOS Electron smoke and integration jobs.

Azure packaged validation 480756 passed packaged Electron smoke and integration tests on Windows, Linux, and macOS. Downloaded integration-task logs confirm all six Agent Host E2E entrypoints actually ran and passed on each platform. Publishing and release are disabled.

The overall Azure build initially failed because the Windows Unit Tests job exceeded its 50-minute job limit during post-test Component Governance. Retried only that canceled Windows job, which reused its successful test checkpoints and completed finalization. Build 480756 is now succeeded on d4bb3c96cbc, with no code, assertion, or job-timeout changes. Checkpoint reuse is not counted as another independent test execution.

All build/test CI checks are green; the draft/review-policy VS Code PR Check remains pending. This does not resolve the separately documented live approve-only concern below.

Remaining live approve-only concern

Keep this PR in draft. Preview.5 still attempts implementation after selecting exit_only (“Approve Plan Only”) in the existing planning scenario: 3/3 local live recording checks failed the unchanged no-pending-confirmation assertion. These were local real-model checks, not CI replay failures:

AGENT_HOST_REPLAY_RECORD=1 VSCODE_SKIP_PRELAUNCH=1 ./scripts/test-integration.sh \
  --run src/vs/platform/agentHost/test/node/e2e/providers/copilotAgentHostE2E.integrationTest.ts \
  --grep 'planning-mode session-state writes are auto-approved in default mode'

Original fixture bytes were restored after every check; no failed recording was accepted. The previously investigated plan-exit notice/approval semantics are not fixed by this bump. Green deterministic replay uses recorded assistant responses and must not be treated as evidence that the live model respects approve-only.

Runtime provenance: cli-1.0.92-5.

(Written by Copilot)

Align root and remote SDK/runtime pins with 1.0.92-5. Handle the SDK's credential-free account authentication variant in connector account selection, with coverage for both provider and token-callback accounts.

(Written by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 5, 2026 16:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The acknowledged live approve-only regression remains unresolved despite the reviewed code and dependency pins being internally consistent.

Review effort: Balanced
Findings: None

What changed in this PR

Updates the Copilot SDK and bundled runtime while supporting the SDK’s new provider-owned account authentication variant.

Changes:

  • Bumps SDK to 1.0.17-preview.5 and runtime to 1.0.92-5.
  • Matches provider-owned accounts using their direct login.
  • Tests both token-provider and provider-owned account selection.
File Description
package.json Updates root SDK and runtime pins.
package-lock.json Refreshes root SDK platform packages.
remote/​package.json Updates remote-server pins.
remote/​package-lock.json Refreshes remote SDK platform packages.
copilotSessionLauncher.ts Supports account-owned login matching.
copilotSessionLauncher.test.ts Covers both authentication variants.
Files not reviewed (1)
  • remote/package-lock.json: Generated file

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@roblourens
roblourens marked this pull request as ready for review October 5, 2026 18:28
@roblourens
roblourens enabled auto-merge (squash) October 5, 2026 18:28
@roblourens
roblourens merged commit 6308cbd into main Oct 5, 2026
63 checks passed
@roblourens
roblourens deleted the agents/upgrade-copilot-sdk-preview-five branch October 5, 2026 21:02
@vs-code-engineering vs-code-engineering Bot added this to the 1.142.0 milestone Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants