docs: fix responseType JSDoc and clarify auth samples#2003
Open
jameshang93 wants to merge 1 commit into
Open
Conversation
Correct the copy-pasted responseType documentation and note that auth samples are illustrative, pointing to the DummyAuthenticationProvider test helper.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a copy-paste JSDoc error on
responseTypeand clarifies that README auth samples are illustrative (with pointers to the local test mock provider). Also replaces a dead UserVoice docs-request link in CONTRIBUTING.Fixes #1755 (JSDoc portion only).
Changes
src/GraphRequest.ts: correctresponseTypeJSDocREADME.md: note that auth samples are illustrative; linktest/DummyAuthenticationProvider.tsCONTRIBUTING.md: route documentation requests to GitHub Issues instead of UserVoiceTest plan
Docs/comments only.