Skip to content

fix(nexus): return portable image artifact paths #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smackgg merged 1 commit into from
Jul 28, 2026
Merged

fix(nexus): return portable image artifact paths #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/plugins/nexus-service/convax-package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"id": "nexus-service",
"name": "Nexus · OpenRouter",
"description": "Connects Convax to the Convax Workspace in Nexus for OpenRouter chat and live image-model generation through short-lived Data Tokens.",
"version": "0.3.6",
"version": "0.3.7",
"license": "MIT",
"compatibility": {
"pluginSchema": "convax.plugin/7",
Expand All @@ -13,7 +13,7 @@
"companions": [
{
"command": "convax-nexus-mcp",
"version": "0.3.5",
"version": "0.3.6",
"source": "packages/tools/nexus-mcp",
"targets": [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/nexus-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@microvoid/convax-plugin-nexus-service",
"version": "0.3.6",
"version": "0.3.7",
"private": true,
"type": "module",
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/nexus-service/package/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"id": "nexus-service",
"name": "Nexus · OpenRouter",
"description": "Connects Convax to the Convax Workspace in Nexus for OpenRouter chat and live image-model generation through short-lived Data Tokens.",
"version": "0.3.6",
"version": "0.3.7",
"contributes": {
"generation": {
"models": [
Expand Down
2 changes: 1 addition & 1 deletion packages/tools/nexus-mcp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@microvoid/convax-nexus-mcp",
"version": "0.3.5",
"version": "0.3.6",
"private": true,
"license": "MIT",
"type": "module",
Expand Down
5 changes: 4 additions & 1 deletion packages/tools/nexus-mcp/src/image-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ export class NexusImageGenerator {
} finally {
await handle.close();
}
artifacts.push({ mimeType: image.mimeType, name, path: outputPath });
// Convax owns output_directory and admits only portable paths relative
// to it. Keep the native path private to this writer and return the
// generated file name through the MCP result contract.
artifacts.push({ mimeType: image.mimeType, name, path: name });
}
return artifacts;
} catch (error) {
Expand Down
4 changes: 3 additions & 1 deletion packages/tools/nexus-mcp/test/image-generator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,10 @@ describe("NexusImageGenerator", () => {
expect(first[0]).toMatchObject({
mimeType: "image/png",
name: "nexus-operation-123-1.png",
path: "nexus-operation-123-1.png",
});
expect(await fs.readFile(first[0]!.path)).toEqual(png);
expect(path.isAbsolute(first[0]!.path)).toBe(false);
expect(await fs.readFile(path.join(root, first[0]!.path))).toEqual(png);
});

test("rejects a model that is no longer in the image-output catalog", async () => {
Expand Down