Repository navigation
fix(modules): say "settings entries", not "settings entrys" - #315
Merged
Merged
Conversation
plural() added an s to every noun, so a deployment with several failed entries reported "2 files, module or settings entrys failed". plural() now takes an irregular plural, and the two failure messages pass theirs. Tests cover plural() itself, and a deployment with two failed entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When several modules or settings entries fail,
configfile modules deployandundeployend with a count of the failures. The message was built by adding ansto the noun, so it read:It now reads:
Other Informations
plural()insrc/output.tstakes an optional plural form for irregular nouns (plural(2, 'entry', 'entries')); the default is still the noun followed bys, so other messages are unchanged.src/commands/modules.tspass their plural, which also puts every noun of the list in the plural ("files, modules or settings entries"). The singular message ("1 file, module or settings entry failed.") is unchanged.plural()call uses an irregular noun.CHANGELOG.mdhas an entry under Fixed.Tests: a unit test for
plural()(singular, zero, plural, irregular plural), and a deployment with two failed entries checking the message.pnpm checkpasses (415 tests).