Handling Xero's rate limits

[rikkipitt]

Hi @minimul,

Xero has API rate limiting. Specifically,

• Minute Limit: 60 calls in a rolling 60 second window
• Daily Limit: 5000 calls in a rolling 24 hour window

Xeroizer allows us to sleep for a number of seconds if the request fails in response to the OAuth::RateLimitExceeded error.

See here for a reference: https://github.com/waynerobinson/xeroizer/blob/master/lib/xeroizer/http.rb#L133

Are you open to adding something similar in? Am I correct there's something similar (in terms of retrying) in your qbo-api?

Cheers,
Rikki

[minimul]

Thanks @rikkipitt for contributing this scenario.

Yes, a library is for handling common patterns but an exceed-rate-limit/sleep/retry feature I'd rather pass on to the developer to handle.

I recently rejected a common pattern/problem (OAuth2 renewal/persistence/retry) feature over on qbo_api because of complexity reasons – which I'd say also applies here.

No, qbo_api doesn't have a similar feature.

Aside:
As for qbo_api projects I'd also recommend for users of this gem to wrap your Xero requests in a similar code pattern for which then you can easily handle this and other scenarios.