Skip to content

Calculation of pad distance in LandFireLatLongBox init insufficient for large map sizes #29

Description

@afennelly-mitre

In commit 7466bde, we introduced the pad_distance attribute to the LandFireLatLongBox class. The pad_distance uses a fixed constant of 100 to pull "extra data" from landfire to ensure that the resulting fuel.shape is equivalent to the user provided area.screen_size tuple.

However, this does not work when using larger map sizes, ie. there is an upper bound when using 100 where if the area.screen_size is above this upper bound, the resulting fuel.shape is no longer equivalent to the provided fuel.shape.

I haven't tested this rigorously to discover the true upper bound, but I have found that setting the constant to 250 upholds the equivalent shape assumption for map sizes less than or equal to (768, 768).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingoperationalHaving to do with operational dataplannedThe project team will work on this issueversion:patchUpdating the patch version x.x.(x + 1)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions