Repository navigation
Retain plan/execute configuration during offline export - #11
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offline export refused conversations containing the planner's plan/execute configuration with
unknown persisted protobuf fields. This change retains that configuration so supported conversations export normally, while unknown fields and unsupported enum values still fail closed.The schema overlay copies only field 60 and its message from the authenticated agy 1.5.7 descriptor closure, preserving historical definitions. The verification profile advances, and synthetic tests cover both generator and executor metadata, optional model presence, full/default comparisons, and lossless offline export.
Validation:
go test ./..., vet, lint, build, and maintenance tests passed (164 passed, 17 skipped). Automatic Wu review completed with zero findings and complete coverage. The reported native source exported all 2 persisted steps in JSON and Markdown without changing its DB/WAL hashes. Native full/default RPC qualification was unavailable because daemon discovery failed.