Skip to content

Support and qualify agy 1.5.8 conversations - #12

Merged
mjacobs merged 4 commits into
mainfrom
compat/agy-1.5.8-pr
Nov 13, 2026
Merged

mjacobs merged 4 commits into
mainfrom
compat/agy-1.5.8-pr

Conversation

@mjacobs

@mjacobs mjacobs commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

agy 1.5.8 saves several tool and storage forms that the reader previously refused. This change supports the observed forms, retains the authenticated release schema, and records the qualified compatibility audit while preserving refusal of unsupported sources.

Design

  • Accept absent redundant SQLite render and permission columns using the complete payload as the authority. Populated copies must still agree; generator metadata accepts either zero or its actual byte length.
  • Add bounded projections for subagent definitions, MCP results and approvals, denied calls, failed reads, hook decode failures, and background cancellation. Nine sanitized full/default fixture pairs exercise acceptance and rejection boundaries. Missing-file ranges retain the historical line-1-to-later-line bound, including hook-free and resultless steps; eight regression cases cover verification and offline refusal.
  • Extend the production schema with only the required subagent and MCP fields through an authenticated generator, retaining historical fields. Preserve the complete 1.5.8 snapshot with readable schemas and checksums.
  • Record the isolated qualification results and limits in the compatibility documentation. Unsupported sources receive no new exemption.

Current state

  • Local make check, race tests, snapshot verification, and all 183 protobuf-enabled maintenance tests pass. Hosted Linux, macOS, and lint checks passed 3/3 on the final PR head. The exact reviewed head was fast-forwarded to main; target-branch CI also passed 3/3 after one lint schema-download timeout was retried.
  • The recorded isolated audit verifies all 15 new scenarios and 499/500 conversations in the broader corpus. The remaining historical failed board-post source stays unsupported; those corpus results are retained audit evidence, not a new corpus run for this PR.
  • This change publishes compatibility support only. It does not install the binary, restart a reader, or deploy a service. Windows, Carbon, enterprise gateway policy, remote transport, and authentication changes were not independently exercised.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T19:04:15.506311Z eaa0fb4 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mjacobs
mjacobs merged commit eaa0fb4 into main Nov 13, 2026
3 checks passed
@mjacobs
mjacobs deleted the compat/agy-1.5.8-pr branch November 13, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant