Skip to content

Support and qualify agy 1.5.5 swarm and workspace sessions - #7

Merged
mjacobs merged 2 commits into
mainfrom
review/agy-1.5.5
Nov 10, 2026
Merged

mjacobs merged 2 commits into
mainfrom
review/agy-1.5.5

Conversation

@mjacobs

@mjacobs mjacobs commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Summary

agy 1.5.5 swarm sessions could retain truncated transcripts because their saved tool results did not pass completeness verification. This change qualifies the observed swarm and workspace results, restores complete exports for the four exercised release conversations, and places child transcripts beneath the creation step identified by their returned conversation ID.

Design

  • Preserve captured swarm result text, arguments, output references, and rendering metadata. Unsupported actions, argument combinations, errors, and additional fields continue to fail closed.
  • Accept observed share/branch workspace invocations, ordered two-child list/kill results, empty task lists, and skill reads with the captured timestamp prefix. Derive metadata from saved content; existing attestations require reverification.
  • Reserve explicit child IDs before chronological fallback. Keep unmatched children visible, and disable fallback for parents containing swarm calls.
  • Record the verified 1.5.5 protobuf snapshot and compatibility report. These mappings require no embedded descriptor changes or new exceptions to source verification.

Current state

  • The recorded qualification passes native full/displayed comparison, offline JSON equality, isolated sync, and attestation validation for all four release scenarios. The corpus sweep fetched/rendered 499/499 conversations and verified 489/499; ten previously recorded historical source/RPC mismatches remain unqualified.
  • Local validation: formatting, Go tests, race tests, vet, lint, and build pass. Python maintenance tests pass: 174 run, 100 skipped. Existing automatic reviews completed with no findings; the snapshot/audit review could not independently inspect private captures.
  • No production reader installation or restart is included. Live downstream re-ingestion was not exercised. See the compatibility report for provenance and exercise limits.

Preserve captured swarm results, accept observed workspace and two-child
payloads, and place child transcripts by returned conversation ID. Keep
unobserved shapes fail-closed.

Include the compatibility audit and qualification record for the four
release scenarios. Historical source/RPC mismatches remain unqualified.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T19:25:12.494925Z 213a04b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mjacobs
mjacobs merged commit 5545256 into main Nov 10, 2026
3 checks passed
@mjacobs
mjacobs deleted the review/agy-1.5.5 branch November 10, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant