Repository navigation
Verify agy 1.5.5 image reads and prevent competing watchers - #8
Merged
Merged
Conversation
Accept valid RFC3339 timestamp prefixes while preserving the full result and checking the media type, including downscaled PNG-to-JPEG images. Give this rule a distinct images155 profile suffix so older attestations and persisted verification checks require fresh verification.
Hold an operating system lock for the watcher lifetime. Overlapping watchers wait without touching the shared store, keep syncing their other stores, and take over after the owner exits. This prevents different reader versions from repeatedly replacing each other's verification records. Deduplicate root aliases while retaining the supplied path for IDE discovery. Reload cached checks on takeover and release ownership on cancellation or crash.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timestamped image reads from agy 1.5.5 now verify successfully while preserving the original result text. Watch mode also prevents overlapping reader processes from repeatedly replacing each other's verification records.
Existing watchers must be restarted with the updated binary to participate in locking. The lock file stays in place after exit.
Validation: regression tests cover timestamp parsing, cache invalidation, process ownership, crash takeover, root aliases, and IDE discovery. Existing Wu reviews completed with all findings settled; Linux, macOS, and lint CI will run on this PR.