Support Kimi K3 Tokenizer - #435
Open
yijingl-nvidia wants to merge 5 commits into
Open
Conversation
Signed-off-by: Yijing Li <257409031+yijingl-nvidia@users.noreply.github.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Author
|
recheck |
Signed-off-by: Yijing Li <257409031+yijingl-nvidia@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=======================================
Coverage ? 81.71%
=======================================
Files ? 146
Lines ? 19373
Branches ? 0
=======================================
Hits ? 15831
Misses ? 3542
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Yijing Li <257409031+yijingl-nvidia@users.noreply.github.com>
Signed-off-by: Yijing Li <257409031+yijingl-nvidia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changed the code's check on tokenizer to accept Kimi K3 tokenizer.
Kimi K3 tokenizer does not inherit from
PreTrainedTokenizerFastbut it is implemented in Rust usingtiktoken.core.Encoding. So it should be accepted by Endpoints to run in the benchmark.Type of change
Testing
Checklist