Skip to content

Support Kimi K3 Tokenizer - #435

Open
yijingl-nvidia wants to merge 5 commits into
mlcommons:mainfrom
yijingl-nvidia:support_kimi_k3
Open

Support Kimi K3 Tokenizer#435
yijingl-nvidia wants to merge 5 commits into
mlcommons:mainfrom
yijingl-nvidia:support_kimi_k3

Conversation

@yijingl-nvidia

@yijingl-nvidia yijingl-nvidia commented Aug 3, 2026

Copy link
Copy Markdown

What does this PR do?

Changed the code's check on tokenizer to accept Kimi K3 tokenizer.

Kimi K3 tokenizer does not inherit from PreTrainedTokenizerFast but it is implemented in Rust using tiktoken.core.Encoding. So it should be accepted by Endpoints to run in the benchmark.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor/cleanup

Testing

  • Tests added/updated
  • All tests pass locally
  • Manual testing completed

Checklist

  • Code follows project style
  • Pre-commit hooks pass
  • Documentation updated (if needed)

Signed-off-by: Yijing Li <257409031+yijingl-nvidia@users.noreply.github.com>
@yijingl-nvidia
yijingl-nvidia requested a review from a team August 3, 2026 23:40
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@yijingl-nvidia

Copy link
Copy Markdown
Author

recheck

Signed-off-by: Yijing Li <257409031+yijingl-nvidia@users.noreply.github.com>
Signed-off-by: Yijing Li <257409031+yijingl-nvidia@users.noreply.github.com>
@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@111cf76). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...utils/services/metrics_aggregator/token_metrics.py 87.80% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage        ?   81.71%           
=======================================
  Files           ?      146           
  Lines           ?    19373           
  Branches        ?        0           
=======================================
  Hits            ?    15831           
  Misses          ?     3542           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Yijing Li <257409031+yijingl-nvidia@users.noreply.github.com>
Signed-off-by: Yijing Li <257409031+yijingl-nvidia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants