Support copying back MLC cached entry for mlc remote-run and mlc slurm-run - #311
Merged
Merged
Conversation
…m-run Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add option to copy back mlc cached entry for remote-run and slurm-run
Support copying back MLC cached entry for mlc remote-run and mlc slurm-run
Aug 16, 2026
Contributor
|
@copilot can you add GitHub action tests for the new changes? |
…_back_mlc_cache Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
Contributor
Author
Added in commit Unit tests —
The |
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
arjunsuresh
requested changes
Aug 16, 2026
Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
arjunsuresh
approved these changes
Aug 17, 2026
anandhu-eng
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds options to copy the MLC cache directory back to the local machine after
mlc remote-runandmlc slurm-runcomplete.remote_run.py--remote_copy_back_mlc_cache— appends the remote MLC cache dir tofiles_to_copy_back, which theremote,run,cmds,sshscript rsync's back. Handles both normal mode (~/MLC/repos/local/cache) and--remote_isolated(absolute temp-dir path, known at command construction time).--remote_copy_back_mlc_cache_path— overrides the local destination; takes precedence over any pre-setpath_to_copy_back_files.slurm_run.py--slurm_copy_back_mlc_cache— inserts anrsync -acommand into the srun job after the script completes. For--slurm_isolatedthis is critical: the cache lives inside the temp dir cleaned up by the EXIT trap, so the copy must run inside srun before exit. For non-isolated + no explicit path, the nodes share the filesystem so the option is a no-op.--slurm_copy_back_mlc_cache_path— overrides the rsync destination (defaults to~/MLC/repos/local/cache).Usage examples:
✅ PR Checklist
✅ Testing & CI
📚 Documentation
📁 File Hygiene & Output Handling
🛡️ Safety & Security
🙌 Contribution Hygiene
Fixes #orCloses #.