Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch_scalar_tensor()created the tensor withrequires_grad = TRUEand then called$squeeze()on it. Since$squeeze()is a tracked autograd op, the returned tensor was no longer a leaf, so.gradwas never populated afterbackward()(as sebffischer diagnosed in the issue thread).This fix squeezes first and only enables
requires_gradafterwards via$requires_grad_(), for the non-tensor-input branch (the tensor-input branch already called$requires_grad_()last and was unaffected). dtype/device handling is unchanged.Added a regression test covering both branches (plain value and tensor input) that checks
is_leafand the gradient value afterbackward().Fixes #1368.