Repository navigation
Add OpenAI 6.2 models without pinning provider catalogs - #32
Conversation
…(HOUSE-131) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Merged into
|
🛑 3 blocking findings🔴 High · Keep capability lookup consistent with paid fallback discovery 🟡 Medium · Keep supplemented catalogs below the Codex response limit 🔵 Low · Avoid shadowing the fixture-read error WalkthroughAdds
Since the last review
Repair promptRead the Details
First review of this pull request. @unfret review · @unfret status · @unfret help |
Summary
Keep OpenAI 6.2 discovery without pinning complete provider catalogs.
Upstream entries take precedence independently by model ID. Free plans are unchanged. This permits removing the studio2 full-catalog overrides that currently stop unrelated model updates.
Evidence
After: both pass on this branch. The tests also prove unrelated Claude and older Codex updates propagate, upstream Sol supersedes only its fallback, native records remain intact, and identical reloads do not churn revisions.
go test ./...and server compile pass on committed head a52b7d6. The implementation lane observed an existing intermittent heartbeat test failure; parent full-suite run passed./v1/modelsand the Codex model endpoint; native instructions were retained. Codex response: 782,287 bytes for that isolated credential set.projects/cliproxyapi/records/2026-11-17-batch-HOUSE-131/in the docs repository.Merge Danger
Door: two-way
The previous binary and private config backup remain available. The full-catalog overrides were removed after deployment and live verification.
Blast Radius: catalogs
Paid Codex registration and client snapshot contents change. Remote refresh code and other provider models are unchanged. The supplemental general entries inherit the predecessor's unverified 128,000 output-token metadata; future upstream entries supersede it.
Acceptance criteria
Gate results
Parent committed head a52b7d6: targeted regression exit 0;
go build -o <scratch>/parent-test-output ./cmd/serverexit 0;go test ./...exit 0. Changed Go files are gofmt-clean. Scoped no-comments review: zero deletions or flags; only required go:embed directives were added.Not verified
Deployed as v8.0.44-mob.7 on studio2; both full-catalog overrides removed; both real /v1/responses requests succeeded and four-host T3 discovery passed. Web search, experimental tools and maximum output length are outside this model-discovery proof. Supplemental records remain dormant when upstream supplies the model; retirement behavior is unchanged from existing local model supplements.
Linear: HOUSE-131
Merged review dispositions
Unfret returned request_changes. All three published mandatory findings were classified under the standing consequence/reachability policy without a fix push:
These are recorded limitations, not code fixes or a green Unfret verdict. No non-Unfret review threads were present.