Repository navigation
Add Gemini 4 Neon to the Antigravity model list - #33
Conversation
✅ Merged into
|
🛑 2 blocking findings🟡 Medium · Preserve fallback metadata for aliased Neon routes 🔵 Low · Shadowed publish error violates the repository naming rule WalkthroughThis PR makes Gemini 4 Neon Low, Medium, and High show up in the Antigravity model list even when the upstream catalog leaves them out. It does this with an embedded fallback catalog that only fills in IDs the upstream catalog is missing, so upstream entries still take precedence. The Codex paid-plan fallback logic is generalized into a shared helper that both providers now use. It also adds a regression test for upstream precedence and for the Low and Medium Neon fallbacks with their single reasoning levels. The author reports live Google discovery and generation checks against Studio2, plus passing builds and tests; production proof is expected after deployment.
Since the last review
Repair promptRead the Details
First review of this pull request. @unfret review · @unfret status · @unfret help |
| // GetAntigravityModels returns the standard Antigravity model definitions. | ||
| func GetAntigravityModels() []*ModelInfo { | ||
| return cloneModelInfos(getModels().Antigravity) | ||
| return withModelFallbacks(cloneModelInfos(getModels().Antigravity), antigravityModelFallbacks) |
There was a problem hiding this comment.
🟡 Medium · Preserve fallback metadata for aliased Neon routes
When Neon is registered only under an OAuth alias with fork:false or a model prefix, execution resolves back to an upstream ID absent from the dynamic registry. LookupStaticModelInfo still scans raw data.Antigravity, so it cannot find these fallbacks. A reproduced high-effort Neon request consequently emits thinkingBudget:24576 instead of thinkingLevel:"high", bypassing the new level-only normalization. The effective fallback definitions also need to be available through static lookup.
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| if _, err := publishCatalogBytes(data); err != nil { |
There was a problem hiding this comment.
🔵 Low · Shadowed publish error violates the repository naming rule
This initializer shadows the err declared by data, err := json.Marshal(remote) at line 25. AGENTS.md explicitly requires method-suffixed names for shadowed variables. Use a call-specific name such as errPublish for this new error binding.
Summary
Evidence
model_not_found.gemini-4-neon.go test ./internal/registry ./sdk/cliproxyandgo build ./cmd/serverpassed. The regression test checks upstream precedence and additive fallback registration.Merge Danger
Door Two-way. Revert the catalog supplement to remove it.
Blast Radius Antigravity model discovery. Codex still uses the same fallback behavior through the shared helper.
Acceptance
Studio2's normal proxy endpoint lists Neon and successfully generates with Neon. Production proof follows deployment. The public catalog continues to refresh.
Scope
XHigh is excluded. Google accepts the XHigh model ID by itself and rejects explicit
thinkingLevel: xhigh.Enable Neon on Studio2 (HOUSE-133)
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.