Update clip wrapper and standardise CRS handling - #18
Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
irm-codebase
changed the title
8 tasks
jnnr
approved these changes
Aug 27, 2026
jnnr
left a comment
jnnr
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I reviewed, but haven't tested. Let me know if I should!
Co-authored-by: Jann Launer <32454596+jnnr@users.noreply.github.com>
Collaborator
|
This looks good, thanks! I will merge it, then test more thoroughly together with some other in-progress additions |
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17, #16, #19
Summary of changes in this pull request
clipwrapper version, and switched to using it for local files. This makes one script unnecessary.slope->slope_deg)NOT_SUITABLEby default (these are mostly swamps, wetlands or estuaries).settings.yaml. The implementation in minimal on purpose. This could be made fully flexible later.Reviewer checklist
pipdependencies in the module's environment files (workflow/envs/).pathvars(e.g.,<results>) in their inputs and outputs.pre-commit.citests pass.INTERFACE.yamlmentions all relevantpathvarsandwildcards.README.mddescribes how to use the module and has the necessary citations.