Repository navigation
scripts: restore server conformance executable bit - #1415
Merged
guglielmo-san merged 1 commit intoOct 19, 2026
Merged
guglielmo-san merged 1 commit into
guglielmo-san merged 1 commit into
Conversation
guglielmo-san
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result-directory fix in #1409 also changed
scripts/server-conformance.shfrom mode 100755 to 100644. The nightly workflow invokes this script directly, so it now exits withPermission deniedbefore running conformance checks.Restore the executable bit. The script contents, including the result-directory fix, remain byte-for-byte identical.
Validation:
./scripts/server-conformance.sh --help: exit 126 before the change, exit 0 afterward.bash -n scripts/server-conformance.shandgit diff --checkpass.The full server conformance suite was not run for this permission-only change. The help path exits before setup or cleanup.
AI assistance: Codex helped reproduce, implement, and verify this change.