Skip to content

docs(pr-flow): make the In Progress / In Review card moves runnable, with a check - #2472

Merged
cliffhall merged 3 commits into
v2/mainfrom
v2/docs/2470-pr-flow-card-moves
Sep 24, 2026
Merged

cliffhall merged 3 commits into
v2/mainfrom
v2/docs/2470-pr-flow-card-moves

Conversation

@cliffhall

Copy link
Copy Markdown
Member

Closes #2470

Agents following /pr-flow kept leaving the card in Todo. Step 1 had a command for the assignment only, and step 6 ended on a trailing sentence with no command. Seen on #2407.

Changes (.claude/skills/pr-flow/SKILL.md only)

  • Step 1 now opens with its own bold rule: Step 1 is two actions — assign the issue, and move its card to In Progress. Both happen before you branch. The code block assigns the issue, moves the card and prints the card's Status at the end. The step is done only when that last line reads card: In Progress.
  • Step 6 replaces the trailing sentence with the same block for In Review, plus the same rule: the step is done only when the PR is linked and the card reads In Review.
  • No /board-ops option ID is copied. The project node ID, the Status field ID and the option ID are all looked up by name when the command runs (gh project view / field-list). The card is found through issue.projectItems, as board-ops does, so an option recreated after a deletion still resolves.
  • Failures are loud. A missing ID means nothing gets edited and the command prints which lookup came back empty. A final status that doesn't match prints this step is NOT done.

Verification

  • I ran the block live on this issue, in bash and zsh. It moved the card and printed card: In Progress. I also mistyped the column name on purpose: it printed lookup failed (… option='' …) — nothing edited and then card is 'In Progress', not 'In Progres' — this step is NOT done.
  • Step 6's block runs right after this PR opens, to move pr-flow: make the In Progress / In Review card moves part of each step's commands, with a check #2470 to In Review.
  • npm run verify:skills passes and npm run local:gate is green.

Eval case (item 5): not added, because no case can observe the move

scripts/skill-eval.mjs records only Skill tool calls and limits the model to Read, Glob, Grep and Skill (ALLOWED_TOOLS). No first-move or chain case can see a gh project item-edit. A chain into board-ops would measure the wrong thing, too: step 1 no longer sends the model there. The description didn't change, so skills:eval wasn't re-run.

🤖 Generated with Claude Code

…with a check (#2470)

Step 1 gave a command for the assignment only, and step 6 ended on a
trailing "Move the card to In Review" sentence, so agents ran the code
block and skipped the card move. Both steps now carry a block that moves
the card and ends by printing its Status; the step is done only when it
prints the target column.

Every id is resolved by name at run time (project, Status field, option)
and the card is found through issue.projectItems, so no /board-ops option
id is copied and a recreated option still resolves.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Assignment failures can be masked, and the Step 6 command does not support v1’s board.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Updates the PR workflow so board status transitions are executable and verifiable.

Changes:

  • Moves cards to In Progress during setup and In Review after PR creation.
  • Resolves board IDs dynamically and verifies resulting status.
File Description
.claude/​skills/​pr-flow/​SKILL.md Adds runnable board-transition commands and checks.

Comment thread .claude/skills/pr-flow/SKILL.md Outdated
Comment thread .claude/skills/pr-flow/SKILL.md Outdated
… board in both blocks (#2472 review)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
@cliffhall
cliffhall requested a balanced review from Copilot September 24, 2026 05:11
@cliffhall

Copy link
Copy Markdown
Member Author

Copilot round 1: 2 findings, both fixed in cfdbe57 (replies are in each thread).

Re-ran local:gate: green. Requested round 2.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The fallback guidance incorrectly directs v1 issues toward board #28 instead of the selected board.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (2)

Comment thread .claude/skills/pr-flow/SKILL.md Outdated
…review)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
@cliffhall

Copy link
Copy Markdown
Member Author

Copilot round 2: 1 finding, fixed in 412944d. The no-card fallback now names the selected board ($BOARD) instead of #28. local:gate is green. Requested round 3.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The workflow now satisfies issue #2470 without duplicating unstable board option IDs.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@cliffhall

Copy link
Copy Markdown
Member Author

Copilot review closed. Round 3 was clean ("Approval recommended", no findings, no inline or suppressed comments), so the loop stopped on the first clean round. In total: 3 rounds, 3 findings, all fixed.

@cliffhall
cliffhall merged commit 06cd7e0 into v2/main Sep 24, 2026
5 checks passed
@cliffhall
cliffhall deleted the v2/docs/2470-pr-flow-card-moves branch September 24, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Issues and PRs for v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pr-flow: make the In Progress / In Review card moves part of each step's commands, with a check

2 participants