fix(ci): publish the tarball by a ./ path so npm reads it as a file - #2552
Merged
Merged
Conversation
The release publish job did `set -- release-tarball/*.tgz` and passed that bare relative path to `npm publish`. npm reads a `dir/file` argument as GitHub `owner/repo` shorthand, so it ran `git ls-remote ssh://git@github.com/release-tarball/…` and failed with Permission denied: 2.9.0 never reached npm. This is the #2483 job split running for the first time; it can only be exercised by a real release. Prefix the glob with ./ so npm treats it as a local file. Reproduced and verified with the pinned npm@11.20.0: the bare path fails with the same git error, and the ./ path dry-runs a publish of the tarball. Closes #2551 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused path correction addresses the reported publish failure without changing the existing safeguards.
Review effort: Balanced
Findings: None
What changed in this PR
This PR fixes the release workflow so npm publishes the downloaded tarball as a local file.
Changes:
- Prefixes the tarball path with
./and documents why it matters.
| File | Description |
|---|---|
.github/workflows/main.yml |
Passes a local tarball path to npm publish. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Copilot review loop closed: round 1 was clean (approval recommended, no findings, no inline or suppressed comments), so no further round was requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2551
Problem
The v2.9.0 release run's
publishjob failed, and 2.9.0 never reached npm (latestis still 2.8.0). Job log:set -- release-tarball/*.tgzpassed a bare relative path tonpm publish. npm readsdir/fileas GitHubowner/reposhorthand and tried to clone it. This is the #2483package/publishsplit running for the first time; only a real release can exercise it.Fix
set -- ./release-tarball/*.tgz, with a comment on why the./matters. Nothing else in the step changes: thepublishConfigrefusal, the name and version re-assertion, and the pinned registry are all as before.Verification
With the CI-pinned npm@11.20.0, on the real 2.9.0 tarball:
release-tarball/modelcontextprotocol-inspector-2.9.0.tgzgit ls-remote ssh://git@github.com/release-tarball/…,Permission denied (publickey)./release-tarball/modelcontextprotocol-inspector-2.9.0.tgzPublishing to https://registry.npmjs.org/ with tag latest and public access (dry-run),@modelcontextprotocol/inspector@2.9.0npm run local:gate→ green (exit 0, 5m05s), includingverify:action-pins.After merge
A release runs the workflow from the tag's commit, so this must reach
mainand the 2.9.0 Release must be re-cut at that commit (tracked on #2551).🤖 Generated with Claude Code