feat(lgr): add ghost node correction data for a GWF-GWF exchange - #2790
Open
jdhughes-dev wants to merge 1 commit into
Open
feat(lgr): add ghost node correction data for a GWF-GWF exchange#2790jdhughes-dev wants to merge 1 commit into
jdhughes-dev wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2790 +/- ##
===========================================
+ Coverage 55.5% 72.7% +17.1%
===========================================
Files 644 662 +18
Lines 124135 132715 +8580
===========================================
+ Hits 68947 96509 +27562
+ Misses 55188 36206 -18982
🚀 New features to boost your workflow:
|
jdhughes-dev
force-pushed
the
feat-lgr-gnc
branch
from
August 4, 2026 21:01
cfffe88 to
e0112b7
Compare
Ghost node data could only be built for the connections inside one model. The connections between two models joined by a GWF-GWF exchange need the same correction, and a local grid refinement pair is the common case. get_gnc_exchange computes the data from the two model grids and the exchange records, and Lgr.get_gnc_data returns it for a parent and child model. The ghost node and its contributing cells are in the first model of the exchange, which must therefore be the coarser one. MODFLOW 6 requires one record for every exchange record in the same order, so a connection that needs no correction, such as a child cell centered on the face of a parent cell, is written with a cellid of zero and a contributing factor of zero. A notebook shows the workflow and compares the corrected and uncorrected solutions against the exact solution for a confined homogeneous problem with a linear head field.
jdhughes-dev
force-pushed
the
feat-lgr-gnc
branch
from
August 4, 2026 23:03
e0112b7 to
89a17d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_gnc_exchangeto compute ghost node correction data for the connections between two models joined by a GWF-GWF exchangeLgr.get_gnc_datato return it for a parent and child model