fix: handle nil message return in internalGo function and add tests f… - #16
Merged
Conversation
…or error message type
Contributor
PR Reviewer Guide 🔍(Review updated until commit 391aa80)Here are some key observations to aid the review process:
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Contributor
|
Persistent review updated to latest commit 391aa80 |
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



User description
…or error message type
PR Type
Bug fix, Tests
Description
Safely handle nil runner messages.
Preserve exit codes for typed nil returns.
Add reusable tests for
anyanderror.Diagram Walkthrough
File Walkthrough
flagrun.go
Handle nil messages from generic runnersflagrun.go
.flagrun_go_test.go
Test nil error runner message handlingflagrun_go_test.go
error-typed runner that returns nil on success.errormessages return an empty string.