test: freeze the open-bucket flush clock - #229
Open
tonyalaribe wants to merge 1 commit into
Open
tonyalaribe wants to merge 1 commit into
tonyalaribe wants to merge 1 commit into
Conversation
ReviewThis is a clean, well-targeted fix for the flake. Summary of what I checked: Correctness of the fix
Scope
Minor observations (non-blocking)
No bugs, security, or performance concerns — this only affects test determinism. Nice minimal fix. |
tonyalaribe
marked this pull request as ready for review
September 8, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The open-bucket force-flush regression can fail when wall time crosses a bucket boundary between inserting its fixture and flushing completed buckets. CI job102022757538 reproduced this at10:20:00 UTC: the completed-bucket flush legitimately drained the newly sealed bucket; retry passed.
Freeze the existing test clock, give the fixture an explicit matching timestamp, and restore wall time with the existing scopeguard dependency even on panic. Both original assertions remain: normal flushing leaves the open bucket, and forced flushing drains it. Production behavior is unchanged.
Validation: formatting and diff checks pass. Full CI is pending; the captured baseline failure is in timefusion-typed-ordering-shard2-passed.log.