[tomatoishealthy]

Summary

Drop GetBlockTraceByNumber from tx-submitter's L2Client interface, together with its L2Clients fan-out implementation and the mock.

The method has no callers in tx-submitter, and the underlying morph_getBlockTraceByNumberOrHash RPC is being removed from go-ethereum along with the matching ethclient helper (companion PR: morph-l2/go-ethereum#388). Without this change, *ethclient.Client would stop satisfying L2Client as soon as the geth dependency is bumped, and tx-submitter/entry.go would fail to compile.

No behavior change.

Merge order

This PR should land before (or together with) the go-ethereum dependency bump that includes the companion PR. It is safe to merge on its own against the current geth version.

Testing

• go build ./..., go vet ./..., go test ./... in tx-submitter: all pass
• Same build / vet against the local go-ethereum branch with the ethclient methods removed: pass (before this change it fails with *ethclient.Client does not implement iface.L2Client (missing method GetBlockTraceByNumber))
• devnet (geth + tx-submitter images built from both branches): tx-submitter commits and finalizes batches normally

🤖 Generated with Claude Code

Summary by CodeRabbit

• Refactor
  • Block trace lookup is no longer available through the transaction-submission client interface or its mock. The client no longer forwards trace requests, and implementations no longer need to provide this operation. Rollup-batch lookup remains unchanged. This is an internal API change and does not describe a new end-user feature.

[claude]

Claude Code Review

Claude Code Review is paused for this repository because its GitHub organization is not linked to your Claude organization.

To turn it back on, one person needs both roles: owner of the GitHub organization (or the account owner, for a personal repository) and admin or owner of your Claude organization. If that is not you, pass this on to someone who is.

Open Organization settings, Git providers and click Link next to the GitHub organization's name. If it is not listed, click Enable GitHub integration or Connect your GitHub first, whichever the page shows.

New pull requests are then reviewed as before. To get a review on one that is already open, someone with write access can comment @claude review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: ff68cea5-33b6-4a33-ad24-fb8541396fbe

📥 Commits

Reviewing files that changed from the base of the PR and between 1cee926 and f953eb2.

📒 Files selected for processing: 2

• tx-submitter/iface/client.go
• tx-submitter/mock/l2client.go

💤 Files with no reviewable changes: 2

• tx-submitter/mock/l2client.go
• tx-submitter/iface/client.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

GetBlockTraceByNumber was removed from the L2Client interface, L2Clients forwarding implementation, and L2ClientWrapper mock.

Changes: Block trace method removal

Layer / File(s)	Summary
Remove block trace method tx-submitter/iface/client.go, tx-submitter/mock/l2client.go	The L2Client interface and L2Clients forwarding implementation no longer define GetBlockTraceByNumber. The mock wrapper no longer provides the method.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor

Suggested reviewers: chengwenxi

Merge Risk: ⚪ Minimal · up to f953e

No remaining callers were found, so the method removal presents no identified merge-blocking risk. Normal build and test checks should still run.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: removing GetBlockTraceByNumber from the tx-submitter L2Client interface.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}