fix(frontend): harden module lifecycle, dialogs, and build tooling

[corneliusio]

Summary

• Tear down and replace module bindings when scopes are re-initialized.
• Improve modal focus management and migrate the lightbox to native dialogs.
• Fix image dimension fallbacks, slide transition flushing, and navigation eager loading.
• Harden Vite, Tinify, installer, environment handling, and formatting configuration.
• Add initialization and lightbox regression coverage.

Testing

• Added Vitest coverage for module re-initialization and lightbox dialog behavior.
• Added jsdom dialog method setup for test execution.
• Not run: repository test, lint, typecheck, or build commands.

Note

Harden module lifecycle, dialog focus trapping, and build tooling

• init.ts now tracks module bindings per scope with a WeakMap, cancels stale pending loads, and tears down modules when their elements disappear — re-initialization replaces bindings instead of stacking them.
• Modal.svelte improves focus trapping to handle elements outside the dialog, restores focus to the previously focused element on close, and adds an aria-label via a new label prop.
• lightbox.ts is reworked to use a native <dialog> element with showModal()/close(), closing on backdrop click or cancel event and restoring focus to the trigger on close.
• vite-plugin-tinify.ts now requires an API key via options and caches image checksums under node_modules/.vite/tinify/ to skip redundant optimizations.
• slide.ts forces a layout flush before starting transitions so slide-up and slide-down animations start from a stable measured height.
• Behavioral Change: craft in global.ts now validates window.$app lazily on first property access rather than at module initialization; config/vite.php restricts the Vite dev server to the dev environment only.

^{Macroscope summarized 2058b7b.}

[greptile-apps]

Greptile Summary

The PR hardens frontend module lifecycle handling, native-dialog behavior, media rendering, navigation loading, environment configuration, and build safeguards.

• Tracks module bindings per scope and prevents superseded dynamic imports from initializing stale elements.
• Migrates lightbox behavior to a native dialog and improves modal focus, keyboard, and scroll management.
• Adds image-dimension fallbacks, transition flushing, eager navigation loading, and safer build/install configuration.
• Adds regression coverage for module reinitialization and lightbox dialog behavior.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
src/lib/init.ts	Adds per-scope lifecycle generations and cleanup replacement; the current pass guard fixes the previously reported stale-import initialization race.
tests/init.test.ts	Covers repeated initialization, superseding an unresolved import with an empty scope, and teardown after element removal.
src/lib/modules/lightbox.ts	Replaces the manual backdrop with a native dialog and updates navigation, dismissal, focus restoration, and cleanup behavior.
src/lib/components/common/Modal.svelte	Improves focus discovery and trapping, active-modal close handling, scroll locking, labeling, and focus restoration.
vite.config.ts	Passes validated Tinify configuration explicitly and prevents builds from emptying the webroot.
src/lib/util/image.ts	Avoids zero-valued doubled transforms and falls back to intrinsic image dimensions.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant Init
    participant Binding
    participant Import
    participant Module
    Caller->>Init: init(scope)
    Init->>Binding: increment selector pass
    Init->>Import: request module
    Caller->>Init: init(scope) again
    Init->>Binding: increment pass again
    Import-->>Init: earlier request resolves
    Init->>Binding: compare captured pass
    Init-->>Import: discard superseded result
    Import-->>Init: latest request resolves
    Init->>Binding: run previous cleanup
    Init->>Module: initialize current elements
    Module-->>Binding: store cleanup

Loading

_{Reviews (2): Last reviewed commit: "fix(init): prevent a superseded pass fro..." | Re-trigger Greptile}

[corneliusio]

@greptile