Bug 2073095 - make the home screen tests safe to be run with different configurations of pinned and sponsored shortcuts - #367
Closed
pollym wants to merge 1 commit into
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
pollym
changed the title
pollym
changed the title
pollym
force-pushed
the
fix-ui-tests-for-nightly
branch
3 times, most recently
from
September 24, 2026 14:01
7aa647a to
642c093
Compare
mcarare
reviewed
Sep 25, 2026
mcarare
approved these changes
Sep 25, 2026
mcarare
left a comment
mcarare
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Should we also remove hardcoded IDs from verifySponsoredShortcutDoesNotExist?
Contributor
Author
|
thanks for the review! 🙌
hmm. looks like that's using |
…t configurations of pinned and sponsored shortcuts. Such as one might find across different locales and build types (: Also locate sponsored shortcuts by their sponsored label. Sponsored shortcuts were located by their absolute position in the top sites list, which assumes a fixed number of pinned shortcuts precedes them. getSponsoredShortcutTitle and verifySponsoredShortcutDetails now take an index among the sponsored shortcuts only, resolved through the sponsored label that only sponsored shortcuts carry. TopSitesTest's setUp asserted the entire default top sites list where, as its comment says, it only needs to wait for the list to be displayed.
pollym
force-pushed
the
fix-ui-tests-for-nightly
branch
from
September 28, 2026 14:03
642c093 to
5838fac
Compare
Contributor
Author
|
added mihai's suggestion + squashed |
lando-worker Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
…t configurations of pinned and sponsored shortcuts r=mcarare Sponsored shortcuts were located by their absolute position in the top sites list, which assumes a fixed number of pinned shortcuts precedes them. getSponsoredShortcutTitle and verifySponsoredShortcutDetails now take an index among the sponsored shortcuts only, resolved through the sponsored label that only sponsored shortcuts carry. TopSitesTest's setUp asserted the entire default top sites list where, as its comment says, it only needs to wait for the list to be displayed. This makes the tests more resilient to changes in top sites and will allow these tests to pass on a nightly build as well as a debug build. [try after rebase is running here]( https://treeherder.mozilla.org/jobs?repo=try&revision=4eed3db2680212ca0e700810435c932a029d1bfd) Pull request: #367
|
Pull request closed by commit a187dc0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sponsored shortcuts were located by their absolute position in the top sites list, which assumes a fixed number of pinned shortcuts precedes them. getSponsoredShortcutTitle and verifySponsoredShortcutDetails now take an index among the sponsored shortcuts only, resolved through the sponsored label that only sponsored shortcuts carry.
TopSitesTest's setUp asserted the entire default top sites list where, as its comment says, it only needs to wait for the list to be displayed.
This makes the tests more resilient to changes in top sites and will allow these tests to pass on a nightly build as well as a debug build.
try after rebase is running here
Lando: link
Bugzilla: bug 2073095
🚫 This pull request has 1 blocker.