Bug 2050856 - Fix Nova survey link colors and focus outline - #374
Closed
jkramer5103 wants to merge 1 commit into
Closed
jkramer5103 wants to merge 1 commit into
jkramer5103 wants to merge 1 commit into
Conversation
No Taskcluster jobs started for this pull requestThe |
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2050856: the Privacy notice button in survey feature callouts uses system link colors and a square default focus outline under Nova.
Use Firefox's link color tokens for the chrome callout theme and include link-styled action buttons in the existing rounded focus styling. Regenerate both stylesheets that consume the shared SCSS. Add browser regression coverage for default, hover, active, and focused styles in light/dark mode with Nova enabled and disabled.
Validation:
git diff --check: passed../mach test --headless browser/components/asrouter/tests/browser/browser_feature_callout.js; unable to run because this sparse checkout has no configured Firefox build and lacks build metadata sources.Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=2050856
Lando: link
Bugzilla: bug 2050856
🚫 This pull request has 1 blocker.