Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
pollym
force-pushed
the
fix-some-more-ui-tests-for-nightly
branch
from
October 2, 2026 16:04
d6e8a56 to
dc8bfcf
Compare
segunfamisa
approved these changes
Oct 5, 2026
pollym
force-pushed
the
fix-some-more-ui-tests-for-nightly
branch
from
October 5, 2026 11:51
dc8bfcf to
1abc430
Compare
- SettingsHomepageTest needed to take into account the differences in top site configuration - SettingsSearchTest needed a reliable way of accessing checkboxes. There was a flaky positional based lookup. i have added a compose testTag to SearchItem facilitate this.
pollym
force-pushed
the
fix-some-more-ui-tests-for-nightly
branch
from
October 5, 2026 14:32
1abc430 to
d3fa791
Compare
lando-worker Bot
pushed a commit
that referenced
this pull request
Oct 5, 2026
- `SettingsHomepageTest` needed to take into account the differences in top site configuration - `SettingsSearchTest` needed a reliable way of accessing checkboxes. There was a flaky positional based lookup. i have added a compose `testTag` to `SearchItem` facilitate this. [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=100176), 3rd attempt with lint fixes Pull request: #378
|
Pull request closed by commit c5c2010 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SettingsHomepageTestneeded to take into account the differences in top site configurationSettingsSearchTestneeded a reliable way of accessing checkboxes. There was a flaky positional based lookup. i have added a composetestTagtoSearchItemfacilitate this.try is running here, 3rd attempt with lint fixes
Lando: link
Bugzilla: bug 2073095
🚫 This pull request has 1 blocker.