Skip to content

Bug 2059493: Clean up components in perfcompare frontend using the unecessary silverman_kde data - #1079

Merged
kala-moz merged 2 commits into
mozilla:mainfrom
kala-moz:mwu-endpoints-cleanup
Aug 17, 2026
Merged

Bug 2059493: Clean up components in perfcompare frontend using the unecessary silverman_kde data#1079
kala-moz merged 2 commits into
mozilla:mainfrom
kala-moz:mwu-endpoints-cleanup

Conversation

@kala-moz

@kala-moz kala-moz commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Bug 2059493

Removes unused Mann-Whitney-U statistics that the frontend no longer reads, so the backend can stop computing and sending them. Two independent cleanups:

1. Drop unused MannWhitneyResultsItem fields

Fields that existed only in the type and test fixtures — never read anywhere in the app:

kde_new, 
kde_base, 
is_fit_good, 
is_significant, 
performance_intepretation (sic), 
warning_c_delta (plus the now-dead KDEItem type).

2. Remove the Silverman KDE feature end-to-end

Drop the silverman_kde field (+ dead SilvermanKDEItem/ModeItem types), remove the Distribution / Estimated Modes rows from the expanded metrics panel, and delete the getModeInterpretation helper that fed them.
Stop sending enable_silverman_kde — remove the silvermanKDEEnabled plumbing from treeherder.ts, all six loaders, useSubtestRegressionCount, and ResultsTable.

Intentionally kept

silverman_warnings (still surfaced by StatisticsWarnings) — separate follow-up if needed.

Notes for the backend

One spelling gotcha: the field is performance_intepretation (missing an "r").

🤖 Generated with Claude's help

@kala-moz
kala-moz requested a review from gopar August 13, 2026 19:08
@netlify

netlify Bot commented Aug 13, 2026

Copy link
Copy Markdown

Deploy Preview for mozilla-perfcompare ready!

Name Link
🔨 Latest commit 5dea821
🔍 Latest deploy log https://app.netlify.com/projects/mozilla-perfcompare/deploys/6a7e162eb3bad60008289c1b
😎 Deploy Preview https://deploy-preview-1079--mozilla-perfcompare.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@kala-moz
kala-moz merged commit f50b4a4 into mozilla:main Aug 17, 2026
8 checks passed
@kala-moz
kala-moz deleted the mwu-endpoints-cleanup branch August 17, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants