Bug 2059493: Clean up components in perfcompare frontend using the unecessary silverman_kde data - #1079
Merged
Merged
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
gopar
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2059493
Removes unused Mann-Whitney-U statistics that the frontend no longer reads, so the backend can stop computing and sending them. Two independent cleanups:
1. Drop unused MannWhitneyResultsItem fields
Fields that existed only in the type and test fixtures — never read anywhere in the app:
2. Remove the Silverman KDE feature end-to-end
Drop the
silverman_kdefield (+ deadSilvermanKDEItem/ModeItemtypes), remove theDistribution / Estimated Modesrows from the expanded metrics panel, and delete thegetModeInterpretationhelper that fed them.Stop sending
enable_silverman_kde— remove thesilvermanKDEEnabledplumbing fromtreeherder.ts, all six loaders,useSubtestRegressionCount, andResultsTable.Intentionally kept
silverman_warnings(still surfaced by StatisticsWarnings) — separate follow-up if needed.Notes for the backend
One spelling gotcha: the field is
performance_intepretation(missing an "r").🤖 Generated with Claude's help