Support TASKING option files and improve response-file caching - #2826
Open
Joldiges wants to merge 3 commits into
Open
Support TASKING option files and improve response-file caching#2826Joldiges wants to merge 3 commits into
Joldiges wants to merge 3 commits into
Conversation
Expand TASKING -f and --option-file arguments before parsing so generated response-file builds can be cached safely. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR makes TASKING VX invocations cacheable when they use -f / --option-file by expanding option-file contents into the argument stream before classification/parsing, so the expanded arguments are included in the cache key.
Changes:
- Expand
-f/--option-file(including abbreviated, concatenated,=-joined, comma-separated, line-continued, quoted, and nested forms) prior toArgsIterparsing. - Update TASKING argument dispositions to allow
=-joined options to be parsed/normalized consistently (CanBeSeparated(b'=')). - Add focused unit tests covering successful expansion and safe fallback cases (missing file, unterminated quotes, nesting limit, and “option-file-like” values that must not expand).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Do not let unknown options containing an inline equals value suppress expansion of a following option-file argument. Cover both populated and empty inline values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Joldiges
marked this pull request as draft
August 27, 2026 20:59
Joldiges
marked this pull request as ready for review
August 28, 2026 15:24
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2826 +/- ##
==========================================
- Coverage 73.71% 70.23% -3.48%
==========================================
Files 72 72
Lines 37932 38266 +334
==========================================
- Hits 27963 26878 -1085
- Misses 9969 11388 +1419 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASKING invocations generated with
-for--option-filewere rejected as non-cacheable because their contained compiler arguments were not expanded before parsing.Expand TASKING option files before argument classification, including joined, separated, abbreviated, quoted, continued, and nested forms. Malformed, unreadable, or excessively nested files fall back safely instead of producing an incomplete cache key. Add focused coverage for the supported forms and failure cases.
GitHub copilot was used for the debugging and resolution of this issue.