Skip to content

msvc: support lots of flags - #2832

Open
AJIOB wants to merge 1 commit into
mozilla:mainfrom
AJIOB:msvc-flags-support-2
Open

msvc: support lots of flags#2832
AJIOB wants to merge 1 commit into
mozilla:mainfrom
AJIOB:msvc-flags-support-2

Conversation

@AJIOB

@AJIOB AJIOB commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

This PR is partially done with AI.

AI search to flags we're not listed and I select what should we do with them.

The full list on flags is gone from https://learn.microsoft.com/en-us/cpp/build/reference/compiler-options-listed-alphabetically?view=msvc-180

For now we support some rarely used MSVC cl.exe flags and provide better details why we skipped caching something (not just "multiple files") for many of flags.

I skipped the flags support from #2831 to minimize conflicts while backporting commits.

P.S. The list of MSVC flags may still not fully complete, but we will have better flags coverage for it

@codecov-commenter

codecov-commenter commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.84%. Comparing base (c710468) to head (4e9c3f3).

Files with missing lines Patch % Lines
src/compiler/msvc.rs 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2832      +/-   ##
==========================================
+ Coverage   73.82%   73.84%   +0.02%     
==========================================
  Files          72       72              
  Lines       38087    38126      +39     
==========================================
+ Hits        28117    28155      +38     
- Misses       9970     9971       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AJIOB
AJIOB force-pushed the msvc-flags-support-2 branch from 9c838d6 to 4e9c3f3 Compare August 30, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants