Wake blocked checkout callers when a connection is discarded - #219
Open
OskarEichler wants to merge 1 commit into
Open
Wake blocked checkout callers when a connection is discarded#219OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wake blocked checkout callers when discarding a connection releases capacity.
TimedStack#decrement_creatednow updates the count under the existing mutex and broadcasts to waiting callers, like the normal checkin path.Previously, a size-one pool could discard its only connection while another caller remained asleep until the full checkout timeout, despite replacement capacity being available.
Reproduction
On installed 3.0.2: ~0.502 seconds. With the fix: under 0.001 seconds in 20 local rounds. These are an isolated contention reproduction, not a general throughput benchmark.
Verification
Limitations and breaking changes
stuberrors. An external verification Gemfile addsminitest-mock, as current upstream does. No test, Gemfile or gemspec changes included.Prepared with Codex assistance.