coordinator: add persistent operation mode - #487
Conversation
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This pull request adds an optional persistent mode to
mana_coordinator.During multi-node MPICH/Hydra checkpoint-and-restart experiments, I found that the coordinator may temporarily have no connected MANA processes between the termination of the original execution and the start of the restarted execution.
The current wrapper always starts DMTCP's coordinator with
--exit-on-last. Consequently, the coordinator can terminate as soon as the final process from the original execution disconnects. The subsequent restart then has no coordinator to reconnect to.This change introduces:
When this option is used, the wrapper does not pass
--exit-on-lasttodmtcp_coordinator. Without--persistent, the current behavior remains unchanged.Refs #485
Motivation
The option is useful when the coordinator is intentionally started independently from the MPI application and is expected to remain available across a checkpoint, process termination, and restart sequence.
This is particularly relevant for distributed MPICH/Hydra executions where:
Without persistent operation, the interval between steps 4 and 5 may cause the coordinator to exit.
Behavior
The existing command:
continues to use
--exit-on-last.The new form:
keeps the coordinator alive when the last client disconnects.
The new option does not change the default behavior.
Implementation
The wrapper now:
--persistentoption;--exit-on-lastonly when persistent mode is explicitly requested;Tests
The pull request adds focused wrapper tests covering:
--exit-on-last;--exit-on-last;The tests use a temporary fake coordinator, so they do not require a running MPI job or a cluster environment.
Validation
I also validated the behavior with a real coordinator process:
--persistent;dmtcp_command --statuscould still query it;dmtcp_command --quit.Scope
This pull request is intentionally limited to the coordinator lifecycle.
It does not include the restart-directory correction, MPICH/Hydra integration test, loader debug-symbol handling, documentation, or the separate DMTCP
PMI_FDproposal described in the umbrella issue.