Repository navigation
ci(docs): install docs dependencies from uv.lock - #1040
Merged
Merged
Conversation
The mkdocs workflow installed mkdocs-material and the revision-date plugin with unpinned pip, so the docs build ran versions that uv.lock did not describe. Move the mkdocs packages into a docs dependency group, included by dev, and have both workflow jobs run mkdocs through uv run --locked --only-group docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pyproject.toml: newdocsdependency group with the three mkdocs packages.devincludes it, souv sync --group devinstalls the same set as before..github/workflows/mkdocs.yaml: the build and deploy jobs runuv run --locked --only-group docs mkdocs ...in place of unpinnedpip install.uv.lock: gains the group entries. No package version changes.Why
The docs build installed whatever versions were newest on the day, so the lockfile and Dependabot alerts on those packages did not describe what CI ran.
Verification
uv run --locked --only-group docs mkdocs build --strictpasses locally in a fresh environment.main, so it is first exercised by the merge.After merge
This merge changes
uv.lockwith no.github/dependabot.ymlpresent. Check that a "Graph Update: uv in /." run appears, which shows whether the dependency graph refreshes on its own.