Skip to content

GitLab sibling plugin on the forge-agnostic seams (follow-up from #4, PR #5) #6

Open

Description

@solalbaudoincs

Following up from #4 (withdrawn — redoing this properly, code first): the forge-agnostic groundwork is now up as PR #5.

What PR #5 does (no behavior change for GitHub, byte-identical wording and merge/clone/draft behavior; 165/165 tests):

  • A forge descriptor (forge.go): name, hosts, PR-URL parsing, refs/pull/N/head, clone/login/token commands, merge-method vocabulary — the GitHub knowledge that lived outside github.go now sits behind one swappable instance.
  • Capability flags on the source interface (reviewRequested, autoMerge): the TUI hides a tab or key a forge can't serve. The demo already exercises this in tests.

This issue tracks the follow-up conversation: a herdr-gitlab sibling plugin standing gitlabForge behind those seams (glab auth, refs/merge-requests/N/head, MR URLs, no review-requested tab, auto-merge via merge_when_pipeline_succeeds). Happy to build it — and happy to adjust the seams in #5 if you'd structure them differently.

Activity

  1. mrolafsson commented on Nov 4, 2026

    @mrolafsson
    Owner

    Thanks for opening this to track it! 🙏 I've replied on #5 with my thinking: I'd love to see GitLab support exist, but I can't maintain a forge I don't use or test, so I think it's best as its own fork (herdr-gitlab). It's most of the way there already in the branch. If shared pieces become clear later, we can look at pulling them out then. I'll leave this open for now while you decide how you'd like to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions