Repository navigation
fix: include regex flags in matches/search query hash - #640
Merged
Merged
Conversation
Queries that differed only by flags shared a Table query-cache entry, so a case-insensitive search could poison a later case-sensitive one. Fixes msiemens#637
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Query.matches/Query.searchclosed overflagsbut omitted them from the query hash, so the table query cache could return results for the wrong flags.flagsin the hash tuple for both methodssearchflags go tore.search(notre.match)Fixes #637
Test plan
uv run py.test tests/test_queries.py -q --mypyJohnfor the case-sensitive search after an ignorecase search