Repository navigation
fix: do not treat str/bytes as sequences in Query.any/all - #641
Merged
msiemens merged 1 commit intoOct 5, 2026
Merged
Conversation
is_sequence() used hasattr(__iter__), so string fields matched any/all as character lists (e.g. name.any(['a','b']) on 'abc'). Use collections.abc.Sequence and exclude str/bytes/bytearray. Fixes msiemens#638
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Query.any/Query.allusedhasattr(obj, '__iter__')for sequence checks, so string fields were treated as character sequences and could false-match (e.g.name.any(['a', 'b'])on'abc').Per discussion on #638, option (1): treat real sequences only and exclude
str/bytes(alsobytearray).Fixes #638
Test plan
uv run py.test tests/test_queries.py -q --mypyany/alltests still passany/allas char lists