Repository navigation
fix: persist_empty must not wipe existing table data - #642
Merged
Merged
Conversation
Only write an empty table when the table has no documents yet. Reopening with persist_empty=True no longer clears stored docs. Fixes msiemens#636
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persist_empty=Truealways calledtable.clear()onTableconstruction, which wiped documents when reopening an existing non-empty table.Per #636 option (1): only persist a new empty table when there are no documents yet.
Fixes #636
Test plan
uv run py.test tests/test_tables.py -q --mypytest_persist_tablestill passespersist_empty=Truekeeps data