Conversation
fallenmi
left a comment
There was a problem hiding this comment.
The fork publishes an attested source artifact, but this PKGBUILD bypasses it. archive/v${pkgver}.tar.gz hashes to 086063ac09b293d2510f08af0e9e4eb52d2856f77295989e2fe4e18135c5cb18, and GitHub has no attestation for that digest. The release asset ncdu-${pkgver}-src.tar.gz hashes to 2eccb4ce6c4e08d9539155789ff7341fdbde67bd746e9f523d5d3095cd872804 and has attestations tied to refs/tags/v1.23.0 and .github/workflows/c-release.yml.
Because this change removes the PGP-verified source specifically because upstream moved to Sigstore, please point source at the attested release asset, update the checksum, and remove the now-unused validpgpkeys. That aligns the pinned bytes with upstream's published provenance. It does not make makepkg verify the attestation automatically—that remains out of band until the packaging workflow adds an explicit verification step—but the currently selected archive has no attestation to verify.
Reviewed with OpenAI Codex and Anthropic Claude assistance.
|
Okay, fixed. I understood the guidelines as to add a new key without removing the old one. |
fallenmi
left a comment
There was a problem hiding this comment.
Thanks — confirmed that the PKGBUILD now uses the attested ncdu-1.23.0-src.tar.gz release asset with its matching SHA-256, and the unused validpgpkeys entry is gone. Both checks pass on this exact head.
Reviewed with OpenAI Codex and Anthropic Claude assistance.
|
hm, tricky, have any other distros switched? Currently there are no real code changes in 1.23.0, so no rush I guess. |
I did not find any, although repology is down, so it's kinda difficult. We can wait with this. The fork continues Yorhel's Zig reboot with some updates to the latest Zig. I found this fork by searching and I think it is the most active one. The biggest problem is when and whether the source will go offline. I've read something on vndb (Yorhel's another project) that his friends will help with paying for servers. |
yeah, repology/repology-rs#560 |
|
Anitya shows this fork |
|
Hello! Nixpkgs actually switched to the BratishkaErik fork back in July: NixOS/nixpkgs@489562d |
Hi, because of unfortunate event described here the work of Yorhel is continued under this fork.
There wasn't any big change for the original C version, but it should be better to update the sources to active fork (at least active for Zig rewrite and maintained for C).
It uses GitHub Attestations (that uses sigstore) instead of PGP, so it is impossible to add a new key.