Rename the Bazel module from smithy_cpp to opal_cpp (#201, ADR-0024) - #210
Merged
Merged
Conversation
Surface 3 of 3; closes the issue. The module is opal_cpp, runtime labels are @opal_cpp//runtime:..., the codegen plugin's default runtimeTarget follows, and the copts constant is OPAL_COPTS. The out-of-tree consumer module carries the migration: bazel_dep and local_path_override renamed, labels substituted, nothing else. The smithy_cpp_*_library rules keep their names: they take a Smithy model as input. Closes #201
Review: ApproveSurface 3 of ADR-0024 looks complete and correctly scoped. Checked the diff against the ADR keep/change table and grepped the branch for leftover Completeness
Intentional non-changes (verified)
Notes (non-blocking)
LGTM for merge once remaining CI legs finish. |
A consumer that sets runtimeTarget in smithy-build.json has a @smithy_cpp// label outside any BUILD file; say so rather than leaving it to "every label".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #201. Surface 3 of 3 per ADR-0024 (#207 namespace, #209 include root). The repository itself is not renamed here.
What
The Bazel module is
opal_cpp:Everything that names the module follows it:
@smithy_cpp//…→@opal_cpp//…in the consumer module, docs,renovate.json, and the codegen plugin's defaultruntimeTarget(@opal_cpp//runtime:core, with the Java tests that assert it).SMITHY_COPTS→OPAL_COPTS: the constant hand-written BUILD files load from//bazel:copts.bzl. The generated BUILD files never loaded it, so the goldens are unchanged (regenerated to confirm: byte-identical).smithy_cpp_consumer→opal_cpp_consumer, andboringssl-resolution-check.shnow queriesbazel mod deps opal_cpp.bazel/defs.bzl,.bazelrc, docs and the plan.Unchanged, by design: the
smithy_cpp_{types,client,server}_libraryrules (they take a Smithy model as input and are named for it),smithy_cpp_codegen_maven(the codegen plugin's Maven repo; the plugin is a Smithy tool), and everysmithy-cpprepository URL. GitHub redirects the old URL once the repo is renamed, and thegit_overridesnippet in the quickstart follows whenever that lands.buildifierre-sorted the consumer's dep lists because@opal_cppsorts differently from@smithy_cpp; that is the only non-substitution churn.Testing
bazel test //... --config=werror: 129 tests pass.examples/bazel-consumer: 15 tests pass against the renamed module, including the boringssl resolution check that doesbazel mod deps opal_cpp. The consumer's diff is the migration recipe:bazel_dep, override, labels, nothing else.cd codegen && gradle build spotlessCheckpasses; goldens regenerate byte-identically.No new tests: no new behavior. The consumer module is the acceptance test for the rename, and its resolution-check script exercises the module name at the
bazel modlevel.Checklist
bazel test //...and(cd codegen && gradle build spotlessCheck)pass locally🤖 Generated with Claude Code
https://claude.ai/code/session_01Jj5X2fKdgrYurHmbwLzUiQ
Generated by Claude Code