build(deps): replace toolchains_llvm with hermetic-llvm 0.8.19 - #218
Merged
Conversation
The --config=llvm cell moves to the hermetic-llvm module (BCR name "llvm"). It is zero-sysroot, so clang gets libc++, compiler-rt, CRT files and the glibc/kernel headers as Bazel targets instead of reading the runner's /usr/include. Same dev-only shape: --extra_toolchains selects @llvm//toolchain:all, so ordinary builds keep the autodetected toolchain. Registers the full set rather than a subset via @llvm//extensions:toolchain.bzl, which declares root_module_direct_deps unconditionally and so cannot be used dev-only. Drops -Wno-unused-command-line-argument, which silenced toolchains_llvm's builtin-libc++ flag noise under --config=werror. The boost.context -std=c++17 per-file flag stays; its headers are still parsed here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7LJEcX1h9jYfE6xt9Mm6G
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the
--config=llvmcell to the hermetic-llvm module (BCR namellvm, 0.8.19). Zero-sysroot, so libc++, compiler-rt and the glibc/kernel headers come from Bazel rather than the runner's/usr/include. Still dev-only and selected via--extra_toolchains.Registers all toolchains instead of a subset — the toolchain extension sets
root_module_direct_depsunconditionally, which Bazel rejects for a dev-only usage.🤖 Generated with Claude Code
https://claude.ai/code/session_01N7LJEcX1h9jYfE6xt9Mm6G