🐛 Export forwarded Qiskit measurement results - #2177
Closed
simon1hofmann wants to merge 8 commits into
Closed
Conversation
Assisted-by: GPT-5.6 via Codex Signed-off-by: Simon Hofmann <simon.t.hofmann@tum.de>
Assisted-by: GPT-5.6 via Codex Signed-off-by: Simon Hofmann <simon.t.hofmann@tum.de>
Assisted-by: GPT-5.6 via Codex Signed-off-by: Simon Hofmann <simon.t.hofmann@tum.de>
Assisted-by: GPT-5.6 via Codex Signed-off-by: Simon Hofmann <simon.t.hofmann@tum.de>
This was referenced Aug 20, 2026
simon1hofmann
force-pushed
the
codex/qiskit-structured-control-export
branch
from
August 21, 2026 14:27
b612830 to
a1d106b
Compare
Signed-off-by: Simon Hofmann <simon.t.hofmann@tum.de>
Keep measurement-store adjacency strict and map only validated post-store measurement results to their destination CBits. Assisted-by: GPT-5.6 via Codex Signed-off-by: Simon Hofmann <simon.t.hofmann@tum.de>
Assisted-by: GPT-5.6 via Codex Signed-off-by: Simon Hofmann <simon.t.hofmann@tum.de>
Record that mapping owns topological ordering and document only the supported post-store result forwarding. Assisted-by: GPT-5.6 via Codex Signed-off-by: Simon Hofmann <simon.t.hofmann@tum.de>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Clbitwhen CBit cleanup forwards a later load to that result.
measurement/store rule: the unique static destination store must remain in
the same block and follow the measurement directly, apart from constants.
destinations fail-closed.
target-specific scheduling machinery. Operation ordering belongs to the
mapping pass and is addressed by ⚡ Implement
reorderForDominancefunction #2240; this exporter does not implement asecond topological scheduler.
The remaining change fixes the Benchpress-produced cleanup form
measure; store; ... use %measurement_resultwithout broadening acceptedinstruction ordering.
Stack
The earlier symbolic-parameter and classical-expression foundations, #2150 and
#2175, are merged into
main.Testing
error and passes on this branch.
test/python/test_mlir_qiskit_translation.py: 219 passed.uvx nox -s stubs: passed; generated stubs are unchanged.uvx nox -s lint: passed.git diff --check: passed.The documentation build was not rerun for this update.
AI assistance: Codex assisted with the merge, overlap analysis, simplification,
implementation, tests, validation, commits, push, and this description.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).