♻️ Consolidate shared MLIR infrastructure by burgholzer · Pull Request #2202 · munich-quantum-toolkit/core

burgholzer · 2026-08-20T17:32:28Z

🤖 AI text below 🤖

Description

This pull request follows #2150 and gives shared compiler infrastructure clear ownership:

Move the cross-dialect global-phase normalization and modifier-unrolling passes from Dialect/Utils to the MQT dialect.
Centralize shared global-phase, parameter, modifier, dense-unitary, and U-gate contracts under Dialect/MQT/Utils without introducing a shared QC/QCO unitary interface.
Move dialect-independent constant-folding helpers to mlir/Support.
Build the quantum-aware module equivalence checker as test support instead of production support.
Remove the remaining project-owned Dialect/Utils files and document the MQT passes.

The existing pass names and behavior remain unchanged. The new layout separates MQT-owned quantum semantics, generic MLIR support, and test-only infrastructure.

Validation completed after rebasing onto the merged #2150:

Release build
4,301 configured CTest tests with 100% success; one QDMI test skipped by its own condition
Generated MLIR documentation
Strict Sphinx documentation build
Repository lint suite

Checklist

The pull request only contains commits that are focused and relevant to this change.
I have added appropriate tests that cover the new/changed functionality.
I have updated the documentation to reflect these changes.
I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
I have added migration instructions to the upgrade guide (if needed).
The changes follow the project's style guidelines and introduce no new warnings.
The changes are fully tested and pass the CI checks.
I have reviewed my own code changes.

If PR contains AI-assisted content:

Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
I have disclosed AI assistance in the PR description.
I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

Move cross-dialect transforms and quantum helpers under the MQT dialect, split generic constant folding into support, and share phase and parameter validation across QC and QCO. Assisted-by: Codex

Build the quantum-aware module equivalence checker only for unit tests and remove its dialect dependencies from the production support library. Assisted-by: Codex

codecov · 2026-08-20T17:41:56Z

Codecov Report

❌ Patch coverage is 96.95740% with 15 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
mlir/include/mlir/Dialect/MQT/Utils/Modifiers.h	88.2%	4 Missing ⚠️
mlir/include/mlir/Dialect/QCO/QCOUtils.h	0.0%	4 Missing ⚠️
mlir/lib/Dialect/MQT/Utils/Modifiers.cpp	88.8%	4 Missing ⚠️
...b/Dialect/MQT/Transforms/NormalizeGlobalPhases.cpp	91.6%	1 Missing ⚠️
mlir/lib/Dialect/QC/IR/Modifiers/ModifierUtils.cpp	0.0%	1 Missing ⚠️
mlir/lib/Dialect/QC/IR/Modifiers/PowOp.cpp	98.6%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

burgholzer · 2026-08-20T17:48:30Z

@denialhaag @simon1hofmann could one of you cross check this? This feels like a pretty natural follow-up to the MQT introduction.

denialhaag

I like this change a lot! Thanks, @burgholzer! 🙂

I have four nitpicks and one actual comment, all of which you can find below.

Keep dialect-independent folding helpers in support infrastructure while making their MQT ownership explicit in the include path and C++ namespace. Assisted-by: Codex

simon1hofmann · 2026-08-20T19:20:07Z

I like this change a lot! Thanks, @burgholzer! 🙂

I have four nitpicks and one actual comment, all of which you can find below.

@denialhaag is too fast with reviews 😅

Use mutable MLIR handles consistently, document the folding contract, fix direct include dependencies, and root-qualify test-support namespace references. Assisted-by: Codex

burgholzer · 2026-08-20T19:51:24Z

@denialhaag I think the latest commit should address most of your concerns (hopefully all). Would you mind to take another look?

coderabbitai · 2026-08-20T20:04:57Z

Important

Approval pending

CodeRabbit has no unresolved comments, but it has not reviewed the latest commit.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

denialhaag

I'll approve because the namespaces are good now. Two of the comments are technically still open, but I don't want to unnecessarily block this. Feel free to resolve and merge. 🙂

Place all IR-aware shared helpers under Dialect/MQT/Utils, split broad utility headers by contract, and move non-template implementations into MLIRMQTUtils. Model direct consumer dependencies explicitly and keep support and dialect registration layers free of the helper target. Assisted-by: Codex

burgholzer · 2026-08-20T22:40:03Z

Okay. Took this for another spin and I think this is now ready to be merged 🚀
I let codex scan the upstream MLIR repository for precedents of how this is typically structured and the changes here are the result of that.
In particular, it argued for putting as much in source files as possible (turning the Utils into a real library) and for putting this under MQT/Utils, which seems to be an established pattern.

I'll tag this for auto-merge now so that it hopefully goes through over night 😴

denialhaag · 2026-08-20T22:46:08Z

Okay. Took this for another spin and I think this is now ready to be merged 🚀
I let codex scan the upstream MLIR repository for precedents of how this is typically structured and the changes here are the result of that.
In particular, it argued for putting as much in source files as possible (turning the Utils into a real library) and for putting this under MQT/Utils, which seems to be an established pattern.

I really like how this looks now! Thanks for addressing all of my comments! 🙂

burgholzer · 2026-08-20T22:57:01Z

I really like how this looks now! Thanks for addressing all of my comments! 🙂

Thanks for the good feedback! 🙌🏼

main moved the contents of `mlir/Dialect/Utils/Utils.h` into the `MQT/Utils` headers in #2202. This file uses none of those symbols, and the replacement includes it does need are already in place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

main moved `IRVerification` out of the library and into `mlir/unittests` in #2202, where the tests include it by its unittest-relative path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

burgholzer added 2 commits August 20, 2026 17:26

♻️ Consolidate shared MLIR infrastructure

3687ef1

Move cross-dialect transforms and quantum helpers under the MQT dialect, split generic constant folding into support, and share phase and parameter validation across QC and QCO. Assisted-by: Codex

♻️ Move IR verification into test support

c7b97e4

Build the quantum-aware module equivalence checker only for unit tests and remove its dialect dependencies from the production support library. Assisted-by: Codex

burgholzer added refactor Anything related to code refactoring code quality Code quality improvements MLIR Anything related to MLIR skip-changelog Changes that do not need to show up in the changelog labels Aug 20, 2026

burgholzer self-assigned this Aug 20, 2026

denialhaag requested changes Aug 20, 2026

View reviewed changes

♻️ Namespace MQT-owned folding support

96a00e9

Keep dialect-independent folding helpers in support infrastructure while making their MQT ownership explicit in the include path and C++ namespace. Assisted-by: Codex

🎨 Address shared infrastructure review

a46472d

Use mutable MLIR handles consistently, document the folding contract, fix direct include dependencies, and root-qualify test-support namespace references. Assisted-by: Codex

denialhaag approved these changes Aug 20, 2026

View reviewed changes

burgholzer added this to the MLIR Support milestone Aug 20, 2026

burgholzer removed the skip-changelog Changes that do not need to show up in the changelog label Aug 20, 2026

burgholzer marked this pull request as ready for review August 20, 2026 22:37

burgholzer merged commit 0c50dd3 into main Aug 20, 2026
26 checks passed

burgholzer deleted the codex/mqt-shared-infrastructure branch August 20, 2026 22:56

Uh oh!

Uh oh!

Conversation

burgholzer commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

codecov Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

burgholzer commented Aug 20, 2026

Uh oh!

denialhaag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

simon1hofmann commented Aug 20, 2026

Uh oh!

burgholzer commented Aug 20, 2026

Uh oh!

coderabbitai Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approval pending

Uh oh!

denialhaag left a comment

Choose a reason for hiding this comment

Uh oh!

burgholzer commented Aug 20, 2026

Uh oh!

denialhaag commented Aug 20, 2026

Uh oh!

Uh oh!

burgholzer commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

burgholzer commented Aug 20, 2026 •

edited

Loading

codecov Bot commented Aug 20, 2026 •

edited

Loading

coderabbitai Bot commented Aug 20, 2026 •

edited

Loading