✨ Add the remaining structured benchmark programs - #2204
Draft
denialhaag wants to merge 2 commits into
Draft
Conversation
Assisted-by: Opus 5 via Claude Code
Assisted-by: Opus 5 via Claude Code
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
🤖 AI text below 🤖
Builds on #2135 and adds the rest of the structured benchmark suite, seventeen programs: block encoding, Toffoli-heavy circuits, quantum fan-out, the Draper adder for a quantum and for a classical input, controlled multiplication modulo N, Shor, Grover with weak measurement, a VQE ansatz with fixed repetitions, QAOA, VQE, ML-QAE, repeat-until-success, magic state distillation, logical state preparation, syndrome measurement and correction, and measurement-based computation.
The programs follow their published constructions. The modular arithmetic of Shor and of the controlled multiplication follows Beauregard, so both share one implementation of the modular adder and the modular multiplication in
BenchmarkUtils. Magic state distillation measures the four stabilizers of the five-qubit code and accepts a round only on a trivial syndrome, after Bravyi and Kitaev.Three programs do not convert to
jeff, and the benchmark record carries alowersToJeffflag that skips thejefftests for them. VQE counts an energy from the measured register, and the modular programs derive their addend at run time; both need anarithoperation thatjeff-mlirhas no pattern for. Every other output format still covers them.That leaves two programs of the suite unimplemented, both marked in the
jeffbenchmark README as needing further research: X-Ray Absorption Spectroscopy and Quantum Metropolis Sampling.AI notice
This PR and its contents were created with the assistance of Opus 5 via Claude Code.
Checklist
I have added migration instructions to the upgrade guide (if needed).If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).